Use variable placeholder when rendering total votes [#2979858]

Problem/Motivation

The total votes is displayed as two separate strings. This makes it harder for translators to get the context required for a good translation.

Proposed resolution

Use a variable placeholder when rendering 'Total votes' in the Poll results.

Remaining tasks

Write a patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#11	2979858-10.patch	8.15 KB	Lendude
#11	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 20 pass
#8	poll-variable_placeholder-2979858-8.patch	9.96 KB	idebr
#8	8.x-1.x: PHP 7 & MySQL 5.5, D8.6 46 pass PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply
#8	interdiff-6-8.txt	6.55 KB	idebr
#6	interdiff-4-6.txt	2.4 KB	idebr
#6	poll-variable_placeholder-2979858-6.patch	3.18 KB	idebr
#6	8.x-1.x: PHP 7 & MySQL 5.5, D8.6 42 pass, 4 fail
#4	poll-variable_placeholder-2979858-4.patch	739 bytes	idebr
#4	8.x-1.x: PHP 7 & MySQL 5.5, D8.6 40 pass, 6 fail
#4	interdiff-2-4.txt	396 bytes	idebr
#2	poll-variable_placeholder-2979858-2.patch	748 bytes	idebr
#2	8.x-1.x: PHP 7 & MySQL 5.5, D8.6 40 pass, 6 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 June 2018 at 13:31

idebr created an issue. See original summary.

Comment #2

idebr CreditAttribution: idebr at ezCompany commented 15 June 2018 at 13:34

Status:

Active

» Needs review

File	Size
poll-variable_placeholder-2979858-2.patch	748 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 40 pass, 6 fail

Attached patch implements a variable placeholder when rendering 'Total votes' in the Poll results, so translators get the context required for a good translation.

Comment #3

15 June 2018 at 13:37

Status:

Needs review

» Needs work

The last submitted patch, 2: poll-variable_placeholder-2979858-2.patch, failed testing. View results

File	Size
interdiff-2-4.txt	396 bytes
poll-variable_placeholder-2979858-4.patch	739 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 40 pass, 6 fail

Comment #5

15 June 2018 at 13:55

Status:

Needs review

» Needs work

The last submitted patch, 4: poll-variable_placeholder-2979858-4.patch, failed testing. View results

File	Size
poll-variable_placeholder-2979858-6.patch	3.18 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 42 pass, 4 fail
interdiff-4-6.txt	2.4 KB

File	Size
interdiff-2-4.txt	396 bytes
poll-variable_placeholder-2979858-4.patch	739 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 40 pass, 6 fail

Comment #7

15 June 2018 at 14:11

Status:

Needs review

» Needs work

The last submitted patch, 6: poll-variable_placeholder-2979858-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

File	Size
poll-variable_placeholder-2979858-6.patch	3.18 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 42 pass, 4 fail
interdiff-4-6.txt	2.4 KB

Comment #10

idebr CreditAttribution: idebr at iO commented 25 November 2019 at 10:21

Status:	Needs work	» Needs review
Issue tags:	-Needs reroll

File	Size
2979858-10.patch	8.15 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 20 pass

2 files were hidden/shown/deleted

File	Size
interdiff-6-8.txt	6.55 KB
poll-variable_placeholder-2979858-8.patch	9.96 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 46 pass PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply

Reroll after #3090356: Convert tests to phpunit was committed.

Comment #11

Lendude

Dutch

Amsterdam

CreditAttribution: Lendude at iO commented 25 November 2019 at 15:26

File	Size
2979858-10.patch	8.15 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 20 pass

3 files were hidden/shown/deleted

File	Size
2979858-10.patch	8.15 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.8 20 pass
interdiff-6-8.txt	6.55 KB
poll-variable_placeholder-2979858-8.patch	9.96 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 46 pass PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply

Rerolled (sorta, was easier to just redo from scratch)

Comment #12

Lendude

Dutch

Amsterdam

CreditAttribution: Lendude at iO commented 26 November 2019 at 07:55

Status:

Needs review

» Reviewed & tested by the community

LOL, only just saw that I didn't refresh the page before uploading and that the reroll was already done! Ignore #11

But that does allow me to review this :D

So, looks great!

Comment #13

26 November 2019 at 19:29

Berdir committed 5693128 on 8.x-1.x authored by idebr

Issue #2979858 by idebr, Lendude: Use variable placeholder when...

Comment #14

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 26 November 2019 at 19:29

Status:

Reviewed & tested by the community

» Fixed

Thanks. This will break existing translations but can't do anything about that, it will also not fix it for people with a customized template, but same, if they did that then the translation worked for them or they fixed it themself there ;)