The JSON API core patch at #2843147-62: Add JSON:API to core as a stable module has 48 fails, 46 of which because of remaining deprecation notices. We should set up JSON API's 2.x branch to have the same failures so we can fix them.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Status: Active » Needs review
FileSize
1.59 KB
Wim Leers’s picture

Now moved it to the right location.

Status: Needs review » Needs work

The last submitted patch, 3: 2982964-3.patch, failed testing. View results

Wim Leers’s picture

Yay, that worked!

Wim Leers’s picture

Status: Needs work » Needs review
Issue tags: +@deprecated
FileSize
3.41 KB
4.97 KB
Wim Leers’s picture

Yay, green again!

I see that there's also 2 CS violations introduced by #2957474: Move the write functionality of config entities to a sub-module in preparation for removal. Let's fix those here too, a separate issue for that seems excessive.

Wim Leers’s picture

Title: Add a drupalci.yml to JSON API » Add a drupalci.yml to JSON API to match Drupal core's and fix all surfaced deprecation errors
Wim Leers’s picture

#6 introduced two other CS violations; fixing those.

Wim Leers’s picture

Issue summary: View changes
Wim Leers’s picture

D'oh.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

  • Wim Leers committed 633e250 on 8.x-2.x
    Issue #2982964 by Wim Leers: Add a drupalci.yml to JSON API to match...
Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed
Wim Leers’s picture

Wim Leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.