Using this module to present different themes based on a query key.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

john.money created an issue. See original summary.

john.money’s picture

FileSize
4.44 KB
263.24 KB

Patch attached.

Admin

john.money’s picture

FileSize
4.44 KB

Fixed null logic for theme_key.

kumkum29’s picture

Very useful patch !!
Do you think include this patch/code in the next version ? (question to maintainers)

Thanks.

kumkum29’s picture

For each configuration, an interesting evolution for this patch is to choose the name of the query, i.e.: ?section=..., ?chapter=...

ressa’s picture

This would be a great feature, thanks for creating the patch @john.money.

deepali_agarwal’s picture

Category: Feature request » Bug report
Status: Active » Fixed

Thank You @john.money for the patch.

@kumkum29: I think, choosing the name of the query, i.e.: ?section=..., ?chapter=... is not required as you can always pass ?theme_key=... and make things work. Besides adding the name of the query will only complicate the module. Reach out to me, if you have any scenario where you cannot pass ?theme_key= and the name of the query is a must, we can discuss and then open a new issue for same.

deepali_agarwal’s picture

Category: Bug report » Feature request
ressa’s picture

Thanks for committing the patch @deepali_agarwal.

I agree with your thoughts about having only one query name. I do think that changing it to something shorter might be worthwhile, from ?theme_key= to perhaps ?tkey=, or even ?tk=. What do you think? Or perhaps it could be configurable from the GUI?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

StijnStroobants’s picture

As I don't want to use a development-release, here is a patch that applies against the current 8.x-1.0 release

But I would suggest to create a new release asap, as the current one is not updated for a few years.