metatag/src/Plugin/metatag/Group contains several groups that are implemented in Metatag submodules: e.g., there's a metatag/src/Plugin/metatag/Group/Twitter Cards.php, while there's also a metatag_twitter_cards module. This can cause some confusion, since adding a tag in metatag/src/Plugin/metatag/Tag that belongs to the Twitter Cards group adds Twitter Cards to the Metadata field even when the Twitter Cards module isn't enabled. Should these groups that are also represented in modules be removed from metatag/src/metatag/Plugin/Group? All of the tags in the Tag directory use either the 'basic' or 'advanced' group, with the exception of MetaNameBase.php: $this->group = $plugin_definition['group'];

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sunset_bill created an issue. See original summary.

sunset_bill’s picture

Issue summary: View changes
sunset_bill’s picture

DamienMcKenna’s picture

Title: Metatag Groups duplicate metatag modules » Move meta tag groups to the appropriate submodule

Lets move the group definitions to the appropriate submodule.

thejimbirch’s picture

Status: Active » Needs review
FileSize
5.08 KB

This patch removes the duplicated group files from the metatag module since they already exist in their respective submodules. There were two differences:

DublinCoreBasic.php in metatag. DublinCore.php in its module.
SiteValidation.php in metatag. SiteVerification.php in its module.

But it looks like the fields used the correct submodule group any way.

DamienMcKenna’s picture

Status: Needs review » Fixed
Parent issue: » #2957104: Plan for Metatag 8.x-1.6

Committed. Thanks Jim!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.