metatag/src/Plugin/metatag/Group contains several groups that are implemented in Metatag submodules: e.g., there's a metatag/src/Plugin/metatag/Group/Twitter Cards.php, while there's also a metatag_twitter_cards module. This can cause some confusion, since adding a tag in metatag/src/Plugin/metatag/Tag that belongs to the Twitter Cards group adds Twitter Cards to the Metadata field even when the Twitter Cards module isn't enabled. Should these groups that are also represented in modules be removed from metatag/src/metatag/Plugin/Group? All of the tags in the Tag directory use either the 'basic' or 'advanced' group, with the exception of MetaNameBase.php: $this->group = $plugin_definition['group'];
Comment | File | Size | Author |
---|---|---|---|
#5 | 2987904-duplicate-group-names-5.patch | 5.08 KB | thejimbirch |
|
Comments
Comment #2
sunset_bill CreditAttribution: sunset_bill commentedComment #3
sunset_bill CreditAttribution: sunset_bill as a volunteer and commentedComment #4
DamienMcKennaLets move the group definitions to the appropriate submodule.
Comment #5
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedThis patch removes the duplicated group files from the metatag module since they already exist in their respective submodules. There were two differences:
DublinCoreBasic.php in metatag. DublinCore.php in its module.
SiteValidation.php in metatag. SiteVerification.php in its module.
But it looks like the fields used the correct submodule group any way.
Comment #7
DamienMcKennaCommitted. Thanks Jim!