Steps to reproduce on distro.gos.net:

1. enable Social gdpr
2. login as admin and create a data policy
3. login as chris hall and see that you are asked to give consent
4. login as benflorez (SM) and see that you are not asked to give consent. See screenshot
5. as admin, change the role of ben to LU.
6. Login as benflorez and observe that you are asked to give consent. See screenshot

This bug has been fixed before, when testing the Feature right before release.

CommentFileSizeAuthor
LU data policy in menu.png441.6 KBEvelienschut
LU consent.png78.8 KBEvelienschut
SM no consent also no item in menu.png437.76 KBEvelienschut
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Evelienschut created an issue. See original summary.

ronaldtebrake’s picture

ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and for Open Social commented
Status: Active » Needs review

PR here:
https://github.com/goalgorilla/open_social/pull/1526

I decided this is only for 7.0 and newer installs so current CM + SM aren't disrupted. If you need this on your current website make sure the permission "without consent" is removed for CM + SM.

You can do that in an update hook by using:

  user_role_revoke_permissions('sitemanager', ['without consent']);
  user_role_revoke_permissions('content_manager', ['without consent']);
ronaldtebrake’s picture

ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and for Open Social commented
Version: 8.x-2.3 » 8.x-7.x-dev
jaapjan’s picture

jaapjan CreditAttribution: jaapjan for Open Social commented
Status: Needs review » Needs work

Marking as needs work since Behat test need to be updated still (since CM/SM now need to give consent )

https://travis-ci.org/goalgorilla/open_social/jobs/591925204

albertoalaejos’s picture

albertoalaejos CreditAttribution: albertoalaejos as a volunteer and for Open Social commented
Status: Needs work » Fixed

  • ronaldtebrake committed 1cefb1f on 8.x-7.x 
    #2994248 by ronaldtebrake: whitespace
  • albertoalaejos authored 2a5f40c on 8.x-7.x
    Merge pull request #1526 from goalgorilla/bugfix/2994248-gdpr

#2994248...
  • ronaldtebrake committed 6815fd3 on 8.x-7.x
    #2994248 by ronaldtebrake: whitespace booboo
  • ronaldtebrake committed 714a95a on 8.x-7.x
    #2994248 by ronaldtebrake: Make sure on install SM + CM also need to...
  • ronaldtebrake committed c37f186 on 8.x-7.x
    #2994248 by ronaldtebrake: new custom step definition for SM with extra...
  • ronaldtebrake committed f2100cf on 8.x-7.x
    #2994248 by ronaldtebrake: Make sure on install SM + CM also need to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.