According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#5 2995711-5.patch457 bytesbendeguz.csirmaz
#2 lightning_core-info-2995711-2.patch651 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
lightning_core-info-2995711-2.patch651 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing issue has been addressed. I made sure that all that were marked core, were in fact in core.

Thanks. Patch applied via simplytest.me.

Marking as RTBC

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Needs work

So this patch looks good, except for one thing: the stuff under components should not be namespaced. Those are internal Lightning things and are not parsed as dependencies. So if the namespacing is removed from those items, I think this is RTBC.

bendeguz.csirmaz’s picture

bendeguz.csirmaz CreditAttribution: bendeguz.csirmaz at Cheppers commented
Status: Needs work » Needs review
FileSize
2995711-5.patch457 bytes

Removed namespaces from components.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Fixed

Committed and pushed to 8.x-3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.