Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
FILE: /var/www/html/tolearn/modules/linked_field/linked_field.module
----------------------------------------------------------------------
FOUND 24 ERRORS AND 9 WARNINGS AFFECTING 17 LINES
----------------------------------------------------------------------
20 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
20 | ERROR | [ ] Missing parameter comment
20 | ERROR | [ ] Missing parameter type
21 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
21 | ERROR | [ ] Missing parameter comment
21 | ERROR | [ ] Missing parameter type
95 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
95 | ERROR | [ ] Missing parameter comment
96 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
96 | ERROR | [ ] Missing parameter comment
97 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
97 | ERROR | [ ] Missing parameter comment
97 | ERROR | [ ] Missing parameter type
98 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
98 | ERROR | [ ] Missing parameter comment
98 | ERROR | [ ] Missing parameter type
99 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
99 | ERROR | [ ] Missing parameter comment
294 | ERROR | [ ] Missing parameter comment
295 | ERROR | [ ] Missing parameter comment
297 | ERROR | [ ] Type hint "array" missing for $element
300 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
331 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
331 | ERROR | [ ] Missing parameter comment
331 | ERROR | [ ] Missing parameter type
332 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
332 | ERROR | [ ] Missing parameter comment
332 | ERROR | [ ] Missing parameter type
360 | ERROR | [x] Expected newline after closing brace
429 | ERROR | [ ] Missing parameter comment
429 | ERROR | [ ] Missing parameter type
430 | ERROR | [ ] Missing parameter comment
459 | ERROR | [x] Expected newline after closing brace
----------------------------------------------------------------------
FILE: ...www/html/tolearn/modules/linked_field/src/LinkedFieldManager.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
79 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
123 | ERROR | [x] Data types in @var tags need to be fully
| | namespaced
159 | ERROR | [x] Expected newline after closing brace
----------------------------------------------------------------------
FILE: ...tolearn/modules/linked_field/src/LinkedFieldManagerInterface.php
----------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 11 LINES
----------------------------------------------------------------------
50 | ERROR | Parameter tags must be defined first in a doc comment
57 | ERROR | Description for the @return value is missing
69 | ERROR | Description for the @return value is missing
83 | ERROR | Description for the @return value is missing
85 | ERROR | Type hint "array" missing for $context
112 | ERROR | Missing parameter type
119 | ERROR | Description for the @return value is missing
121 | ERROR | Type hint "array" missing for $data
121 | ERROR | Type hint "array" missing for $options
138 | ERROR | Missing parameter comment
138 | ERROR | Missing parameter type
139 | ERROR | Missing parameter comment
139 | ERROR | Missing parameter type
141 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#2 | 3000461-coding-standard-2.patch | 9.15 KB | deepanker_bhalla |
Comments
Comment #2
deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commentedFixed the coding standard issues.
Comment #4
deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commentedComment #5
vdenis CreditAttribution: vdenis at Agiledrop - Your Trusted Drupal Teammates commentedTested patch and applying ok. No coding standard issues when checking with
phpcs --standard=Drupal
.Comment #6
deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commentedHi @denisveg,
Since no issues are left. Thus i am making it to RTBC.
Comment #8
yannickooThank you for helping here Deepanker, I have comitted an adjusted version of your patch :)
Comment #9
PaulDinelle CreditAttribution: PaulDinelle at Fenix Solutions Inc commentedThis was committed, but it adds a duplicate
use
statement that breaks site installation.Line 8 has a duplicate
use Drupal\Component\Utility\NestedArray;
which was added as part of this patch.Comment #10
PaulDinelle CreditAttribution: PaulDinelle at Fenix Solutions Inc commentedComment #12
joelpittet