According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#6 Screen Shot 2018-09-24 at 1.14.43 PM.png23.59 KBvolkswagenchick
#4 search_api_stats-info-3001985-4.patch1.03 KBalonaoneill
#4 interdiff-3001985-2-4.txt605 bytesalonaoneill
#3 Screen Shot 2018-09-24 at 9.37.30 AM.png23.47 KBvolkswagenchick
#2 search_api_stats-info-3001985-2.patch452 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
search_api_stats-info-3001985-2.patch452 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Title: Dependency namespacing in .info.yml file » Dependency namespacing in .info.yml file and capitalize name of module
Status: Needs review » Needs work
FileSize
Screen Shot 2018-09-24 at 9.37.30 AM.png23.47 KB

Changed the name of the issue, it looks like you went ahead and capitalized the name of the project as per: https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Code looks good. Dependency namespacing was addressed. Patch applied via simplytest.me. Screenshot attached of Extend page.

Although - i did noticed the submodule is not capitalized. Marking needs work. Thanks!

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs work » Needs review
FileSize
interdiff-3001985-2-4.txt605 bytes
search_api_stats-info-3001985-4.patch1.03 KB
alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented

I uploaded a patch that Capitalize the name of the submodule in the .info.yml file.
Interdiff added.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2018-09-24 at 1.14.43 PM.png23.59 KB

Looks good, thanks for including an interdiff. Patch applied using simplytest.me and both module names are now in title case on extend page.

screenshot attached, marking RTBC

  • mandclu committed 3abc1be on 8.x-1.x authored by alonaoneill 
    Issue #3001985 by alonaoneill, volkswagenchick: Dependency namespacing...
mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, and for the feedback. Merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.