Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Thalles created an issue. See original summary.

thalles’s picture

Status: Needs work » Needs review
FileSize
14.1 KB

Hi, follow a litle conttribution

Status: Needs review » Needs work

The last submitted patch, 2: coding_standards-taxonomy_menu-3003707.patch, failed testing. View results

thalles’s picture

Status: Needs work » Needs review
FileSize
14.97 KB

Now with changes on TaxonomyMenuInterface.php

thalles’s picture

Assigned: thalles » Unassigned
andrey.troeglazov’s picture

Assigned: Unassigned » andrey.troeglazov
andrey.troeglazov’s picture

Assigned: andrey.troeglazov » Unassigned
Status: Needs review » Needs work

You should not use any @codingStandardsIgnoreLine use dependency injection instead.

Pranali.addweb’s picture

Assigned: Unassigned » Pranali.addweb
Snehal Brahmbhatt’s picture

Status: Needs work » Needs review
FileSize
13.28 KB

Resolved all dependency injection and other coding standard issues. like: @param comment description, Indentation and etc

Status: Needs review » Needs work

The last submitted patch, 9: taxonomy_menu-3003707-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

Can we divide this issue into several? One per file?

thalles’s picture

This would make it easier to check and apply the patches.
example: https://www.drupal.org/project/taxonomy_menu/issues/3022555

andrey.troeglazov’s picture

No, follow this issue.

thalles’s picture

thalles’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: taxonomy_menu-Coding_standards-3003707-14-D8.patch, failed testing. View results

thalles’s picture

Status: Needs work » Needs review
FileSize
15.34 KB

Follow the patch!

Status: Needs review » Needs work

The last submitted patch, 17: taxonomy_menu-Coding_standards-3003707-17-D8.patch, failed testing. View results

Karan Sen’s picture

thalles’s picture

Status: Needs work » Needs review
suparnaa.dey’s picture

RTBC

volkswagenchick’s picture

Issue summary: View changes
andrey.troeglazov’s picture

Assigned: Pranali.addweb » Unassigned
volkswagenchick’s picture

Issue tags: +dcnj19
patelmayank7552’s picture

Status: Needs review » Needs work

Hi @thalles,

The patch in #19 needs work. Still some coding standard are not fixed.

Thanks and regards.

Mayank Patel

patelmayank7552’s picture

Status: Needs work » Needs review
FileSize
13.34 KB

Hi @thalles,

I have fixed the coding standards for this module.

Please review it.

Thanks and regards,
Mayank Patel

Status: Needs review » Needs work

The last submitted patch, 26: coding_standards-3003707-25.patch, failed testing. View results

volkswagenchick’s picture

Please excuse me, but I'd like to insert some advice.

When commenting about a patch review, please indicate what steps were taken to believe it is ready to change status (moving to rtbc or needs work) . This helps those who are new to the issue queue move forward with a new patch.

Also when changing an improving a patch, it is recommended that an interdiff is added. This makes review easier.
https://www.drupal.org/documentation/git/interdiff

Thanks for helping move the Drupal project forward!!

elaman’s picture

Status: Needs work » Needs review
FileSize
15.58 KB
9.33 KB

Coding standards using phpcs.

andrey.troeglazov’s picture

Issue tags: -dcnj19
andrey.troeglazov’s picture

Issue tags: +Taxonomy Menu Release 8.x-3.5

andrey.troeglazov’s picture

Status: Needs review » Fixed
andrey.troeglazov’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna’s picture

Issue tags: -Taxonomy Menu Release 8.x-3.5