Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Some Warning and errors of default Drupal
Proposed resolution
Format code and comments
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#29 | interdiff-26-29.txt | 9.33 KB | elaman |
#29 | 3003707-29.patch | 15.58 KB | elaman |
| |||
#26 | coding_standards-3003707-25.patch | 13.34 KB | patelmayank7552 |
| |||
#19 | taxonomy_menu-Coding_standards-3003707-19-D8.patch | 10.33 KB | Karan Sen |
| |||
#17 | taxonomy_menu-Coding_standards-3003707-17-D8.patch | 15.34 KB | thalles |
|
Comments
Comment #2
thallesHi, follow a litle conttribution
Comment #4
thallesNow with changes on TaxonomyMenuInterface.php
Comment #5
thallesComment #6
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #7
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedYou should not use any @codingStandardsIgnoreLine use dependency injection instead.
Comment #8
Pranali.addweb CreditAttribution: Pranali.addweb at AddWeb Solution Pvt. Ltd. commentedComment #9
Snehal Brahmbhatt CreditAttribution: Snehal Brahmbhatt at AddWeb Solution Pvt. Ltd. commentedResolved all dependency injection and other coding standard issues. like: @param comment description, Indentation and etc
Comment #11
thallesCan we divide this issue into several? One per file?
Comment #12
thallesThis would make it easier to check and apply the patches.
example: https://www.drupal.org/project/taxonomy_menu/issues/3022555
Comment #13
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedNo, follow this issue.
Comment #14
thallesFollow the patch!
Comment #15
thallesComment #17
thallesFollow the patch!
Comment #19
Karan Sen CreditAttribution: Karan Sen as a volunteer and at Srijan | A Material+ Company commentedPlease review the patch.
Comment #20
thallesComment #21
suparnaa.dey CreditAttribution: suparnaa.dey as a volunteer commentedRTBC
Comment #22
volkswagenchickComment #23
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #24
volkswagenchickComment #25
patelmayank7552 CreditAttribution: patelmayank7552 at ITT Digital commentedHi @thalles,
The patch in #19 needs work. Still some coding standard are not fixed.
Thanks and regards.
Mayank Patel
Comment #26
patelmayank7552 CreditAttribution: patelmayank7552 at ITT Digital commentedHi @thalles,
I have fixed the coding standards for this module.
Please review it.
Thanks and regards,
Mayank Patel
Comment #28
volkswagenchickPlease excuse me, but I'd like to insert some advice.
When commenting about a patch review, please indicate what steps were taken to believe it is ready to change status (moving to rtbc or needs work) . This helps those who are new to the issue queue move forward with a new patch.
Also when changing an improving a patch, it is recommended that an interdiff is added. This makes review easier.
https://www.drupal.org/documentation/git/interdiff
Thanks for helping move the Drupal project forward!!
Comment #29
elamanCoding standards using phpcs.
Comment #30
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #31
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #33
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #34
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #36
DamienMcKennaComment #37
DamienMcKenna