The replicator file has to call to t() that should be replaced by $this->t().

CommentFileSizeAuthor
#7 dependency_injection_for_t_calls-3004635-7.patch724 bytesLaravZ
#2 dependency_injection_for_t_calls-3004635-2.patch1.08 KBLaravZ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LaravZ created an issue. See original summary.

LaravZ’s picture

LaravZ CreditAttribution: LaravZ at Ordina Digital Services commented
Status: Active » Needs review
FileSize
dependency_injection_for_t_calls-3004635-2.patch1.08 KB

  • dawehner committed dc877a3 on 8.x-1.x authored by LaravZ 
    Issue #3004635 by LaravZ: Replicator: t() calls should be avoided in...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Fixed

One patch at a time :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yoruvo’s picture

yoruvo CreditAttribution: yoruvo commented

Sadly this is an incorrect fix.

The website encountered an unexpected error. Please try again later.
Error: Call to undefined method Drupal\replicate\Replicator::t() in Drupal\replicate\Replicator->postCloneEntityField() (line 191 of modules/contrib/replicate/src/Replicator.php).

LaravZ’s picture

LaravZ CreditAttribution: LaravZ as a volunteer commented
FileSize
dependency_injection_for_t_calls-3004635-7.patch724 bytes

This can either be fixed by removing the new code or by adding (for example) the StringTranslationTrait.

@ivi.arocom, can you try the following patch for now? I guess automated testing should also be added, since this error was not caught. Though perhaps this should be a new issue (not too sure about whether we can remain working in this one).