It looks like the readme.md in the module hasn't been updated. The hook examples are missing the word "Field".

And the example to get the view can't work as well, rather use overview_field_load_view()

CommentFileSizeAuthor
#4 readmeupdate-3015063-4.patch1.41 KByens
#2 readmeupdate-3015063-2.patch679 bytesyens
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nielsaers created an issue. See original summary.

yens’s picture

yens CreditAttribution: yens at Dropsolid commented
FileSize
readmeupdate-3015063-2.patch679 bytes

Added the patch, needs review

brentg’s picture

brentg
Primary language Dutch
Location Ghent
CreditAttribution: brentg as a volunteer commented
Status: Active » Needs work

Hi Yens, the patch already looks good, but some things will have to be added I'm afraid.

You've changed the comments above the functions, but the functions itself are wrong as well.
You can have a look at the Usage part on https://www.drupal.org/project/overview_field to get the correct example.
The Readme.md should reflect the page on drupal.org.

Also, if you've updated the patch, you can change the status to 'needs review'

yens’s picture

yens CreditAttribution: yens at Dropsolid commented
FileSize
readmeupdate-3015063-4.patch1.41 KB

Updated the patch to include the updated functions.

yens’s picture

yens CreditAttribution: yens at Dropsolid commented
Status: Needs work » Needs review

  • brentgees committed 5322af3 on 8.x-1.x authored by yens 
    Issue #3015063 by yens: Update readme.md the examples given there don't...
brentg’s picture

brentg
Primary language Dutch
Location Ghent
CreditAttribution: brentg as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.