Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Resolve all the warnings outputted in the following page.
https://pareview.sh/pareview/https-git.drupal.org-project-cloud.git
This is a subsequent task of Comply with Drupal code standard
Comment | File | Size | Author |
---|---|---|---|
#14 | No3_8-3016016-14.patch | 47.78 KB | shidat |
| |||
#8 | no_php_code_tag-3016016.patch | 535 bytes | shidat |
| |||
#7 | no_blank_line_following_inline_comment-3016016.patch | 17.24 KB | shidat |
| |||
#6 | dependencies_prefixed_project-3016016.patch | 1.01 KB | shidat |
| |||
#5 | concat_surrounded-3016016.patch | 2.2 KB | shidat |
|
Comments
Comment #2
shidat CreditAttribution: shidat commentedERROR | Visibility must be declared on method
Comment #3
shidat CreditAttribution: shidat commentedERROR | Expected 1 blank line after function; 0 found
Comment #4
shidat CreditAttribution: shidat commentedERROR | The PHP open tag must be followed by exactly one blank line
Comment #5
shidat CreditAttribution: shidat commentedERROR | Concat operator must be surrounded by a single space
Comment #6
shidat CreditAttribution: shidat commentedWARNING | All dependencies must be prefixed with the project name, for example "drupal:"
Comment #7
shidat CreditAttribution: shidat commentedWARNING | There must be no blank line following an inline comment
Comment #8
shidat CreditAttribution: shidat commentedWARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using | | short open tags but PHP does not allow them.
Comment #9
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #12
yas@shidat All patches are good to me. I'll push and merge the ones.
Comment #13
yas@shidat Unfortunately, the patch
expected_one_blank_line_after_func-3016016.patch
couldn't be applied. And also, could you aggregate all patches in this issue? --- I apple one patch: visibility_declared_on_method-3016016.patchComment #14
shidat CreditAttribution: shidat commentedI merged all the other patch files except visibility_declared_on_method-3016016.patch. Please take a look at the new patch file, thanks.
Comment #15
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #16
yas@shidat
Thank you for clean up the patches. It looks good to me. I'(ll merge it.
Comment #18
yas