Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

shidat’s picture

ERROR | Visibility must be declared on method

shidat’s picture

ERROR | Expected 1 blank line after function; 0 found

shidat’s picture

ERROR | The PHP open tag must be followed by exactly one blank line

shidat’s picture

ERROR | Concat operator must be surrounded by a single space

shidat’s picture

WARNING | All dependencies must be prefixed with the project name, for example "drupal:"

shidat’s picture

WARNING | There must be no blank line following an inline comment

shidat’s picture

WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using | | short open tags but PHP does not allow them.

Xiaohua Guan’s picture

Status: Active » Needs review

The last submitted patch, 3: expected_one_blank_line_after_func-3016016.patch, failed testing. View results

  • yas committed 7f1fe06 on 8.x-1.x authored by shidat
    Issue #3016016 by shidat, yas: Comply with Drupal code standard (2):...
yas’s picture

Status: Needs review » Reviewed & tested by the community

@shidat All patches are good to me. I'll push and merge the ones.

yas’s picture

Status: Reviewed & tested by the community » Needs work

@shidat Unfortunately, the patch expected_one_blank_line_after_func-3016016.patch couldn't be applied. And also, could you aggregate all patches in this issue? --- I apple one patch: visibility_declared_on_method-3016016.patch

 so far.

<code>
Cloning into 'cloud'...
remote: Counting objects: 6202, done.
remote: Compressing objects: 100% (4754/4754), done.
remote: Total 6202 (delta 4212), reused 1659 (delta 991)
Receiving objects: 100% (6202/6202), 2.06 MiB | 343.00 KiB/s, done.
Resolving deltas: 100% (4212/4212), done.
Checking patch modules/cloud_server_template/src/Controller/CloudServerTemplateController.php...
Hunk #1 succeeded at 225 (offset 17 lines).
Checking patch modules/cloud_server_template/src/Entity/CloudServerTemplate.php...
Checking patch modules/cloud_server_template/src/Entity/CloudServerTemplateInterface.php...
Checking patch modules/cloud_server_template/src/Plugin/CloudServerTemplatePluginManager.php...
Checking patch modules/cloud_server_template/src/Plugin/Derivative/CloudServerTemplateCloudContextBundleDeriver.php...
Checking patch modules/cloud_server_template/src/Plugin/Derivative/CloudServerTemplateMenuLinks.php...
Checking patch modules/cloud_server_template/src/Plugin/Derivative/CloudServerTemplateTab.php...
Checking patch modules/cloud_server_template/tests/src/Functional/CloudServerTemplateTest.php...
Hunk #1 succeeded at 294 (offset 95 lines).
Checking patch modules/cloud_service_providers/aws_cloud/src/Aws/Ec2/ApiControllerInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Aws/Ec2/InstanceInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Aws/Ec2/KeyPairInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Aws/Ec2/SnapshotInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/ElasticIp.php...
error: while searching for:
    return $this->get('network_interface_owner')->value;
  }


  /**
   * {@inheritdoc}
   */

error: patch failed: modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/ElasticIp.php:136
error: modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/ElasticIp.php: patch does not apply
Checking patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/Instance.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/Volume.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Config/AwsCloudAdminSettings.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/ElasticIpDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/ImageDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceLaunchForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/KeyPairDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/NetworkInterfaceDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/SecurityGroupDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/SnapshotDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/VolumeDeleteForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Validation/Constraint/AWSConstraintValidator.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/views/filter/TextToSelectFilter.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/AwsEc2Service.php...
Hunk #4 succeeded at 1259 (offset 13 lines).
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/AwsEc2ServiceInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/AwsCloudTestCase.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/ImageTest.php...
error: while searching for:
    $mock_data['DescribeImages']['Images'][0]['Name'] = $name;
    $this->updateMockDataToConfig($mock_data);
  }
}

error: patch failed: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/ImageTest.php:237
error: modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/ImageTest.php: patch does not apply
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php...
Hunk #1 succeeded at 332 (offset 42 lines).
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Utils.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Unit/Service/AwsEc2ServiceMock.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Unit/Service/AwsEc2ServiceTest.php...
Checking patch src/Controller/CloudConfigController.php...
Checking patch src/Entity/CloudConfig.php...
Checking patch src/Entity/CloudConfigInterface.php...
Checking patch src/Entity/CloudContentEntityBase.php...
Checking patch src/Plugin/CloudConfigPluginManager.php...
Checking patch src/Plugin/Derivative/CloudConfigCloudContextBundleDeriver.php...
Checking patch src/Plugin/views/field/ServerTemplateListLink.php...
On branch 8.x-1.x
Your branch is up to date with 'origin/8.x-1.x'.

nothing to commit, working tree clean
shidat’s picture

I merged all the other patch files except visibility_declared_on_method-3016016.patch. Please take a look at the new patch file, thanks.

Xiaohua Guan’s picture

Status: Needs work » Needs review
yas’s picture

Status: Needs review » Reviewed & tested by the community

@shidat

Thank you for clean up the patches. It looks good to me. I'(ll merge it.

  • yas committed 7b46b3d on 8.x-1.x authored by shidat
    Issue #3016016 by shidat, yas, Xiaohua Guan: Comply with Drupal code...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.