Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Context and context ui does not install if the Menu Trail by Path module is installed.
Comment | File | Size | Author |
---|---|---|---|
#13 | context-Install_fails-3018331-d8-13.patch | 3.23 KB | paulocs |
#11 | context-Install_fails-3018331-d8-11.patch | 3.23 KB | paulocs |
#10 | context-Install_fails-3018331-d8-10.patch | 3.26 KB | paulocs |
#4 | context-install-fails-3018331-3.patch | 2.98 KB | anzcar |
Comments
Comment #2
anzcar CreditAttribution: anzcar commentedHey, you are correct, these two modules do cause fatal error and break a site. Problem is they both alter "menu.active_trail" service by applying own class and adding different arguments.
Here is a quick fix that solves fatal error and gives Menu Trail by Path ability to manipulate Menus and warns users that Context Menu reactions are handled by Menu Trail by Path module instead of Context module. (Added two checks - one in ContextServiceProvider and one in .module.)
Comment #3
anzcar CreditAttribution: anzcar commentedComment #4
anzcar CreditAttribution: anzcar commentedCorrected a typo.
Comment #5
bzoks CreditAttribution: bzoks at Agiledrop - Your Trusted Drupal Teammates commentedReviewed patch in #4, tested and works as expected.
Comment #6
Stephen OllmanTested patch against a Drupal GovCMS 8 distribution and works as advertised,
Thanks!
Comment #7
Stephen OllmanWill this patch be rolled out soon?
A number of sites are waiting for it to become part of the stable release.
Comment #8
maticb CreditAttribution: maticb commentedI think this is being held back by the fact that there is a hardcoded reference to another module. If this patch would go through, I think it should be on a more general level, e.g.: "If you are using a different menu service provider, this may not work", and the purpose of this patch should be to catch any such examples, not just one specific module.
How exactly to implement this, is a different question. We would need to somehow figure out if any of the installed modules overrides this, and then show this warning (dynamic - not with hardcoded values to only 1 module)
Comment #9
paulocsI agree with @maticb.
Let's see if we find a better solution.
Comment #10
paulocsHello @all,
here is a new patch.
I don't know if the best approach but what I did is that I verified if the core service were changed before. If so, it will display a warning like patch #4 telling the user that this reaction will not work.
Thanks.
Comment #11
paulocsPatch re-rolled.
Comment #13
paulocsFix code standard.
Comment #15
paulocsComment #17
paulocsFixed in dev branch.
Comment #18
AaronBaumancross-posting #3170929: ContainerNotInitializedException: \Drupal::$container is not initialized yet.
looks like this change is causing a fatal error during bootstrap