Add test case for Volume Attach and Detach

@baldwin,

Could you please repeat the test like the following code ? (c.f. https://www.drupal.org/project/cloud/issues/3017114)

const MAX_TEST_REPEAT_COUNT = 3;

public function testVolumeAttachDetach() {
  $this->_testVolumeAttachDetachRepeat($max_test_repeat_count = MAX_TEST_REPEAT_COUNT);
}

private function _testVolumeAttachDetachRepeat($max_test_repeat_count = 1) {
  for ($i = 0; $ < max_test_repeat_count; $i++) {
    // Actual test code here
  }
}

@baldwinlouie

Thank you for adding the loop.

As we discussed inhttps://www.drupal.org/project/cloud/issues/3017114, what about the following as our default test case design pattern for repeating? We can show our intention to the other developer, that we repeat the test by giving the max repeat count parameter explicitly.

const MAX_TEST_REPEAT_COUNT = 3;

public function testVolumeAttachDetach() {
  $this->_testVolumeAttachDetachRepeat($max_test_repeat_count = MAX_TEST_REPEAT_COUNT);
}

private function _testVolumeAttachDetachRepeat($max_test_repeat_count = 1) {
  for ($i = 0; $ < max_test_repeat_count; $i++) {
    // Actual test code here
  }
}

@baldwinlouie

Thank you for the modification. Now it looks good to me.

@xiaohua-guan

Do you agree to the patch?

@yas

It looks ok to me. And I changed the status to RTBC.

@baldwinlouie
@xiaohua-guan

I merged it and closed this issue. Thank you for your contribution!

Looks good, I'll merge the patch. Thanks!