When we start from a dump from a staging/development site, we sometimes get the following error:

in_array() expects parameter 2 to be array, null given in /environment_indicator/environment_indicator.module on line 314

This is fixable by just submitting the config form again, and probably more related to something in our workflow then our module, but wouldn't hurt to add a check in the code for null.

CommentFileSizeAuthor
#5 3020895-environment-inarray-null-5.patch855 bytescobenash
#2 environment_indicator-in_array_null-3020895-2-D8.patch917 bytesbrentg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brentgees created an issue. See original summary.

brentg’s picture

brentg
Primary language Dutch
Location Ghent
CreditAttribution: brentg at Dropsolid commented
FileSize
environment_indicator-in_array_null-3020895-2-D8.patch917 bytes
brentg’s picture

brentg
Primary language Dutch
Location Ghent
CreditAttribution: brentg at Dropsolid commented
Status: Active » Needs review
leopaccanaro’s picture

leopaccanaro CreditAttribution: leopaccanaro at CI&T commented

Hi @brentgees
Wouldn't it make more sense to use is_array() instead of empty() to check if \Drupal::config('environment_indicator.settings')->get('toolbar_integration')) returns an array?

cobenash’s picture

cobenash
Location Taipei
CreditAttribution: cobenash commented
FileSize
3020895-environment-inarray-null-5.patch855 bytes

I agree with @leopaccanaro.

Modify with a new one.

StefanieV’s picture

StefanieV CreditAttribution: StefanieV commented

Patch #5 works for me. Thanks!

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Assigned: Unassigned » pratik_kamble
pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Status: Needs review » Reviewed & tested by the community

Thanks @cobenash and @brentgees for the patch.
Checked patch in comment #5, adding check in the code for NULL makes sense. I have tried patch locally, by deleting the config from the database and then checking the issue. No error/warning occurs. Patch LGTM.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Status: Reviewed & tested by the community » Fixed
pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Assigned: pratik_kamble » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.