Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Bugs worth fixing:
* #3024558: Username regenerated improperly after rc6 release
* #3034828: Username is not available even when 'change own username' is set
* #3084055: Email Registration breaks commerce panes on old versions of commerce
* #3037323: Remove usage of deprecated methods and functions
Good ideas worth an extra look:
* #3074324: [2.x] E-mail should be required when admins create a user
* #2856542: [2.x] Allow authentication via mail and password over RPC and 2 child ones
* #423920: [2.x] Prevent race condition in account generation code by adding uid to name
Maybe:
* #2957603: Unique Name not working when called externally
* #2935622: Switch to hook_user_presave() for setting username
What else?
Comments
Comment #2
gregglesThinking more on this and I'm not sure we should hold it back until 2935622 is fixed. That change is potentially valuable and worthwhile and also disruptive (making it a good candidate before 1.0). However...I'm not likely to work on it and we've lived a long time without it, so...seems OK to push.
Comment #3
gregglesComment #4
gregglesComment #5
andypostI'd like to get in
- #2856542: [2.x] Allow authentication via mail and password over RPC as it has tests bet needs more eyes
- #2987060: Commerce 2 Completion Registration checkout pane looks ready but have no preference on implmentation
Comment #6
gregglesThanks for your thoughts, andypost!
Both of those feel like they'd be fine to wait for after 8.x-1.0.
I feel like I should create a 8.x-1.0-rc7 very soon (like right now), commit #3034828 just after, and then plan on the 8.x-1.0 in 2 weeks if there are no new criticals. What do you think of that plan?
Comment #7
andypostrc7++ right now and 2 weeks should be enough
Comment #8
andypostAdded #3037323: Remove usage of deprecated methods and functions to bugs, low hanging fruit
Comment #9
gregglesOK, I created https://www.drupal.org/project/email_registration/releases/8.x-1.0-rc7
@andypost I'd love your review of 3034848 if you can.
Comment #10
andypostWill check tomorrow https://www.drupal.org/project/email_registration/issues/3034828
Comment #11
gregglesComment #12
gregglesAdding a commerce related fix that seems like a critical bug to me. Luckily it has a good patch.
Comment #13
andypostI think it ready to be commited with composer fix only #3084055: Email Registration breaks commerce panes on old versions of commerce
the remaining deprecations could be split to fix obvious ones and the remains after release which we could target to 8.7.7 and declare d9 support
Comment #14
gregglesI'm open to that plan laid out in #13. Do you think we need one more stable release or just another ~week for any feedback/bugs to surface and then create the 8.x-1.0 final?
Comment #15
andypostIMO #3037323-16: Remove usage of deprecated methods and functions is ready and we can roll a release
Comment #16
andypostCleaned summary and added forgotten #423920: [2.x] Prevent race condition in account generation code by adding uid to name
Comment #17
gregglesI think it could be good to make a 1.0 release with the current state of the code.
The changes in 3037323 and 423920 seem good, but we should ship a 1.0 for folks to use and those don't seem to be 100% ready just yet.
It's been 2 weeks since the last commits and no new issues are opened. I plan to do a 1.0 if there are no objections in the next few days.
Comment #18
andypostYes, that's perfect time!
Comment #19
gregglesOK, great. Created at https://www.drupal.org/project/email_registration/releases/8.x-1.0
Comment #20
Chris Matthews CreditAttribution: Chris Matthews commentedThanks so much!