t() calls should be avoided in classes use $this->t()

CommentFileSizeAuthor
#2 translation-3023622-2.patch11.75 KBmahtab_alam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mahtab_alam created an issue. See original summary.

mahtab_alam’s picture

mahtab_alam CreditAttribution: mahtab_alam at Valuebound commented
FileSize
translation-3023622-2.patch11.75 KB
mahtab_alam’s picture

mahtab_alam CreditAttribution: mahtab_alam at Valuebound commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: translation-3023622-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Title: t() calls should be avoided in classes use $this->t() » Use $this->t()
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Title: Use $this->t() » Code standards: use $this->t()

  • johnv committed 7cd2170 on 8.x-1.x authored by mahtab_alam 
    Issue #3023622 by mahtab_alam: Code standards: use ->t()
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented

thanks. leaving thsi a 'needs work' since
- i did not test src/Plugin/Action/WorkflowStateActionBase.php yet
- there are many more remaining calls to t()

mahtab_alam’s picture

mahtab_alam CreditAttribution: mahtab_alam at Valuebound commented

I will look into this if there is any remaining t()

@johnv why this task is moved to needs work?

  • johnv committed f328871 on 8.x-1.x 
    Issue #3023622: Code standards: use ->t() in workflow_access
mahtab_alam’s picture

mahtab_alam CreditAttribution: mahtab_alam at Valuebound commented
Status: Needs work » Fixed
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Status: Fixed » Active

because this task is not completed, ,yet.
We can create a new issue for each file, but that is not efficient.
And, I did not test and not implement src/Plugin/Action/WorkflowStateActionBase.php yet

  • johnv committed 57ca805 on 8.x-1.x authored by mahtab_alam 
    Issue #3023622 by mahtab_alam, johnv: Code standards: use $this->t()
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Version: 8.x-1.x-dev » 8.x-1.1
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.