Problem/Motivation

When inbox block is attached to the page, the thread html ID in inbox block is the same like thread on private message page.

Steps to reproduce

  • Attach Private Message Inbox block, show only on
    /private_messages
/private_messages/*

    pages

  • Create 2 threads to users
  • go to the /private_messages/1 page
  • In dev tools, you can see that in source code #private-message-thread-1 exists 2 times

Proposed resolution

  • Use Html::getUniqueId() in PrivateMessageThreadViewBuilder.php class to generate unique ID
  • Check js scripts to avoid issues with selectors
  • Write tests
CommentFileSizeAuthor
#2 private_message-unique_id-3025707-2.patch3.02 KBlamp5
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented
Status: Active » Needs review
FileSize
private_message-unique_id-3025707-2.patch3.02 KB

  • anmolgoyal74 committed 020a25f on 8.x-1.x authored by lamp5 
    Issue #3025707 by lamp5: Thread HTML ID attribute is not unique
anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.