There is an unfortunate spelling mistake in the hint text of an input field on the config page:

Allowed counties for the mobile number. If none selected, then all are allowed.

Situation is a bit confusing, because the word "county" is a valid term in English, meaning a sub-level region of a state or country. So it can be unclear for someone whether the mobile phone number has any relation to the selected region or not? However, the title of the input field says "Allowed Countries" and the list also contains options of country names. (See string ID#2543337 on l.d.o)

It can be seen even on the screenshot illustrating the project page itself:
Screenshot from project page

CommentFileSizeAuthor
#3 counties-rename-3028028-3.patch2.32 KBNeslee Canil Pinto
3028024-typo-fix-7x.patch807 bytesBalu Ertl
3028024-typo-fix-8x.patch2.32 KBBalu Ertl

Issue fork mobile_number-3028028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Balu Ertl created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, 3028024-typo-fix-7x.patch, failed testing. View results

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Needs review
FileSize
counties-rename-3028028-3.patch2.32 KB

Renamed Counties

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Reviewed & tested by the community
Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer and at Brainsum commented
Assigned: Balu Ertl » Unassigned

@Neslee Thanks for the updated patch.

Now tests are passing, so waiting for module maintainer to incorporate changes.

nyariv made their first commit to this issue’s fork.

nyariv opened merge request !4

  • nyariv committed b5c0a32 on 8.x-1.x 
    Issue #3028028 by Balu Ertl, Neslee Canil Pinto: Fix a typo in a UI...
nyariv’s picture

nyariv CreditAttribution: nyariv commented
Status: Reviewed & tested by the community » Fixed
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab commented
Version: 8.x-1.0-alpha5 » 8.x-1.x-dev
Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer and at Cheppers commented
Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer and at Cheppers commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.