Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
WidgetBase passes itself along when invoking alters, allowing third party code to have access to their third party settings.
FormatterBase does not pass along the third party settings.
Proposed resolution
Add it to the pile of information passed along
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#10 | 3029627-tps-10-interdiff.txt | 1.02 KB | bobbygryzynger |
#10 | 3029627-tps-10.patch | 3.39 KB | bobbygryzynger |
#10 | 3029627-tps-10-test-only.patch | 2.77 KB | bobbygryzynger |
#2 | 3029627-tps-2.patch | 635 bytes | tim.plunkett |
Comments
Comment #2
tim.plunkettComment #4
fenstratThis makes sense.
Comment #5
xjmThanks @fenstrat!
I think this still needs test coverage, though.
Comment #6
bobbygryzyngerAdds test coverage.
Comment #7
bobbygryzyngerCleans up namespace copypasta.
Comment #8
bobbygryzyngerComment #9
johnwebdev CreditAttribution: johnwebdev commentedentity_get_display is deprecated
Comment #10
bobbygryzyngerReplaces deprecated function call.
Comment #12
tim.plunkettGreat work @bobbygryzynger, thanks!
Comment #13
xjmGreat work on the test coverage!
Can we have a small CR to let extending forms/alters know this is now available? Thanks!
Comment #14
bobbygryzyngerI started a CR, but feel free to edit it. I wrote up the use-case for #3001313: Field blocks in the layout builder do not have view mode suggestions, but there are likely others that could be added.
Comment #15
bobbygryzyngerComment #16
tim.plunkettThanks @bobbygryzynger, that looks good! I tweaked it only slightly.
Comment #17
alexpottSaving credit.
Comment #18
alexpottCommitted a40136a and pushed to 8.8.x. Thanks!
I think there are good arguments that this should be backported to 8.7.x but I didn't do that because of the change record. If you want that to be done please re-open and and get release manager approval.
Comment #21
AnybodyConfirming that the patch applies to 8.7.3 where it helped to fix this issue: #3018654: Fences seems to be ignored by Layout Builder. So +1 for a backport to 8.7.x!
Comment #22
tim.plunkettReopened for backport, as it blocks #3001313: Field blocks in the layout builder do not have view mode suggestions from backport
Comment #25
annisar CreditAttribution: annisar commentedI confirm this patch works in 8.7x. Along with the patch 3001313-41 on https://www.drupal.org/project/drupal/issues/3001313 I am able to get the view mode suggestions.
Comment #26
AnybodyWe're also using this on 8.7.x successfully since a month. RTBC!
Comment #27
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedFollowing as a reminder to commit #3018654: Fences seems to be ignored by Layout Builder, if this gets backported.
Comment #28
larowlanComment #29
catchSince this is blocking at least one more issue and the actual change is adding an additional array key I think it's fine to backport. Removing the tag.
Comment #31
larowlanc/p as 94f798456c to 8.7.x