Latest ctools broke entity_browser #2981048: Fix wrong EntityBrowserWizard construct argument, which was fixed with #3020353: Test needs update due to change in Drupal 8.7, which breaks the form_alter used in entity_browser_enhanced.

To see the problem try the entity_browser 8.x-2.x-dev release

CommentFileSizeAuthor
#3 entity-browser-enhanced-fix-incompatibility-with-latest-3032666-3.patch4.79 KBoknate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pasqualle created an issue. See original summary.

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle as a volunteer commented 
$form_state->getTemporaryValue('wizard')['entity_browser'];

needs to be changed to 

$form_state->getFormObject()->getEntity();

and some form_id-s adjusted

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Status: Active » Needs review
FileSize
entity-browser-enhanced-fix-incompatibility-with-latest-3032666-3.patch4.79 KB

Here's a patch that should fix the issue.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Assigned: Unassigned » Mohammed J. Razem
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Assigned: Mohammed J. Razem » Unassigned
guedressel’s picture

guedressel CreditAttribution: guedressel at CYLEDGE commented

Patch works for me - though I haven't reviewed it in detail...

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Status: Needs review » Reviewed & tested by the community
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Title: Module broken with latest entity_browser » Fix module broken issue with latest entity_browser

  • RajabNatshah committed 04c4ea0 on 8.x-1.x authored by oknate 
    Issue #3032666 by oknate, Pasqualle: Fix module broken issue with latest...
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented

Committed ... Thank you :)

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.