Problem/Motivation

Remove all the occurrence of drupal_set_message() is deprecated

Proposed resolution

Drupal 8.5.x has introduced a new messenger service. use messenger service to remove deprecation
#2774931

CommentFileSizeAuthor
#16 linkback-3034734-16.patch11.38 KBdaiwik.addweb
#13 deprecated_drupal_setmessege_removed-3034734-13.patch11.38 KBakshay_d
#11 deprecated_drupal_setmessege_removed-3034734-11.patch12.08 KBakshay_d
#9 interdiff_5-9.txt1.54 KBakshay_d
#9 deprecated_drupal_setmessege_removed-3034734-9.patch11.14 KBakshay_d
#5 interdiff-3034734-2-5.patch9.6 KBakshay_d
#2 deprecated_drupal_setmessege_removed-3034734-2.patch5.97 KBakshay_d
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Active » Needs review
FileSize
deprecated_drupal_setmessege_removed-3034734-2.patch5.97 KB

removed deprecated drupal_set_message() in submodule linkback_webmention please review

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Needs review » Needs work

Hi and thanks for the patch. It make sense, despite that it makes mandatory the use of system >8.5, but anyway this is recommended (as <8,4 is not supported).
But as we use dependency injection where it can be used, the use of '@messenger' service must be injected.

Could you change it? (if not I'll do some day)

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Assigned: Unassigned » akshay_d

@aleix I will make the changes soon

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Needs work » Needs review
FileSize
interdiff-3034734-2-5.patch9.6 KB

dependency injection used, please review

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Needs review » Needs work

Ok, thank's but @messenger it's not included in https://cgit.drupalcode.org/linkback/tree/linkback_webmention/linkback_w... .

aleix’s picture

aleix CreditAttribution: aleix commented

The same as pingback submodule #3034744: drupal_set_message() is deprecated in submodule linkback_pingback must be done. If you need help tell me please.

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented

@aleix thanks i will do the changes soon

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Needs work » Needs review
FileSize
deprecated_drupal_setmessege_removed-3034734-9.patch11.14 KB
interdiff_5-9.txt1.54 KB

@aleix updated the services.yml please review.

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Needs review » Needs work

Hi again, everything ok but for form plugin. When using dependency injection in Form creation, it needs to override the create static function to provide the new dependency from container, take a look at:

https://www.drupal.org/docs/8/api/services-and-dependency-injection/depe...

I cannot create the interdiff showing it now sorry... can you refactor it?

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Needs work » Needs review
FileSize
deprecated_drupal_setmessege_removed-3034734-11.patch12.08 KB

updated static function for the new dependency container, please review

Status: Needs review » Needs work

The last submitted patch, 11: deprecated_drupal_setmessege_removed-3034734-11.patch, failed testing. View results

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Needs work » Needs review
FileSize
deprecated_drupal_setmessege_removed-3034734-13.patch11.38 KB

updated patch please review

Status: Needs review » Needs work

The last submitted patch, 13: deprecated_drupal_setmessege_removed-3034734-13.patch, failed testing. View results

aleix’s picture

aleix CreditAttribution: aleix commented

Patch is not applying with last dev, please could you refactor it?

daiwik.addweb’s picture

daiwik.addweb CreditAttribution: daiwik.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
linkback-3034734-16.patch11.38 KB

@aleix, Please find below attached Rerolled patch, as #13 didn't apply to check. Kindly review it & let me know your views on the same.

Thanks!.

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Needs review » Fixed

Great! thank's a lot!

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Fixed » Closed (fixed)