Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-13.txt | 3.74 KB | amateescu |
#13 | 3034757-13.patch | 5.92 KB | amateescu |
| |||
#11 | 3034757-11.patch | 2.18 KB | shubham.prakash |
| |||
#9 | 3034757-9.patch | 2.18 KB | shubham.prakash |
| |||
#7 | deprecated_assertequal_removed-3034757-7.patch | 2.26 KB | Sahana _N |
Comments
Comment #2
Shruthi Shetty M CreditAttribution: Shruthi Shetty M commentedRemoved calls to deprecated method assertEqual() and replaced it with assertEquals().
Comment #3
idebr CreditAttribution: idebr at ezCompany commentedThe arguments for
$actual, $expected
are inverted between::assertEqual()
and::assertEqual()
, so the test assertions should be swapped as well.Comment #4
Sahana _N CreditAttribution: Sahana _N at Specbee commentedremoved deprecated method please review
Comment #5
Sahana _N CreditAttribution: Sahana _N at Specbee commentedComment #7
Sahana _N CreditAttribution: Sahana _N at Specbee commentedremoved deprecated method please review
Comment #9
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedHope this patch fixes the issue.
Comment #10
Berdirthe arguments here need to be inverted too.
Comment #11
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedThis patch should fix the issue.
Comment #12
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedComment #13
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThe patch is missing the most important part mentioned in the issue title: the conversion of
assertEqual()
toassertEquals()
or equivalent methods.Comment #14
BerdirThanks, fixed some spacing and case problems on commit.