Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#16 | 3036287-16.patch | 22.49 KB | Xiaohua Guan |
|
Comment | File | Size | Author |
---|---|---|---|
#16 | 3036287-16.patch | 22.49 KB | Xiaohua Guan |
|
Comments
Comment #2
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #3
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #4
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #5
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
Please review the patch file. Thanks.
Comment #6
yasComment #7
yasComment #8
yas@xiaohua-guan
Thank you for the patch. It looks great. Here is the screenshot for us-east-1 and ap-northeast-1.
us-east-1
ap-northeast-1
I want to request the following minor cosmetic changes:
Hourly ($)
,Daily ($)
,Monthly ($)
,1 Year ($)
,3 Year ($)
.On-demand Hourly ($)
, the floating number digits should be four (e.g.1.2345
or4.5678
(rounded value) for micro instance types.On-demand Daily ($)
andOn-demand Monthly ($)
, the floating number digits should be two (e.g.1.23
or4.56
(rounded value)On-demand Yearly ($)
, the number can be an integer (rounded value) because it is easy to compare toRI 1 Year ($)
.Instance Type Prices
into Server Template's Add / Edit page.Comment #9
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #10
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
I fixed the code. Please review the latest patch file. Thanks.
Comment #11
yas@xiaohua-guan
Thank you for your update. It looks good to me, and I would like to have the following further request to make it perfect:
vertical-align: middle;
to all table elements (headers and rows)@baldwinlouie
What do you think?
Comment #12
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #13
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
Thanks for your comment. I fixed the code as you said. Please take a look again. Thanks.
Comment #14
yas@xiaohua-guan,
Thank you for the update patch. It looks perfect to me but sorry, can you "Add an action link for Instance Type Prices into Server Template's Add / Edit page." for a new browser window?
Comment #15
baldwinlouie CreditAttribution: baldwinlouie commented@yas and @xiaohua-guan, Code looks good to me.
Comment #16
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #17
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
> can you "Add an action link for Instance Type Prices into Server Template's Add / Edit page." for a new browser window?
Yes, I make the link to open as a new window.
Please review the patch file. Thanks.
Comment #18
yas@xiaohua-guan
Great, thank you for the update! I'll merge the patch and close the issue as
Fixed
. Thank you for your efforts.Comment #20
yas