CommentFileSizeAuthor
#9 3038238.png274.41 KBthalles
#7 replace-deprecated-method-drupal_set_message-3038238-2.patch5.68 KBmaliknaik
#6 replace-deprecated-method-drupal_set_message-3038238-1.patch6.09 KBmaliknaik
#4 replace-deprecated-method-drupal_set_message-3038238.patch8.29 KBmaliknaik
#2 Replace-deprecated-method-drupal-set-message-3038238-2.patch5.42 KBMaithri Shetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Maithri Shetty created an issue. See original summary.

Maithri Shetty’s picture

Maithri Shetty CreditAttribution: Maithri Shetty at Specbee commented
FileSize
Replace-deprecated-method-drupal-set-message-3038238-2.patch5.42 KB

Replaced deprecated method drupal-set-message() calls with \Drupal::messenger()->addMessage()

Maithri Shetty’s picture

Maithri Shetty CreditAttribution: Maithri Shetty at Specbee commented
Status: Active » Needs review
maliknaik’s picture

maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commented
FileSize
replace-deprecated-method-drupal_set_message-3038238.patch8.29 KB

Used MessengerTraits insted of \Drupal::messenger()->addMessage().

Status: Needs review » Needs work

The last submitted patch, 4: replace-deprecated-method-drupal_set_message-3038238.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

maliknaik’s picture

maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commented
FileSize
replace-deprecated-method-drupal_set_message-3038238-1.patch6.09 KB
maliknaik’s picture

maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commented
FileSize
replace-deprecated-method-drupal_set_message-3038238-2.patch5.68 KB

Used MessengerTrait and also used the method messenger() defined in the base class of the ConfigFormBase, FormBase, EntityConfirmFormBase, and EntityForm

maliknaik’s picture

maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
3038238.png274.41 KB

Works for me!

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Reviewed & tested by the community » Fixed

This was fixed as part of #3042586, thanks :)

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Issue tags: +Captcha Release 8.x-1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.