CommentFileSizeAuthor
#7 search_api_override-coding-standards-3039493-7.patch4.38 KBsolideogloria
#2 search-api-override-coding-standard-3039493.patch3.93 KBdaiwik.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoshniPatel.addweb created an issue. See original summary.

daiwik.addweb’s picture

daiwik.addweb CreditAttribution: daiwik.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
search-api-override-coding-standard-3039493.patch3.93 KB

Here's the patch that Resolves the type hinting error and coding standard Errors.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Active » Needs work

Please re-roll the patch of #2. Thank you!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: daiwik.addweb » Unassigned
solideogloria’s picture

solideogloria CreditAttribution: solideogloria commented
Parent issue: » #2201697: Plan for Search API Override v7.x-1.0
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
solideogloria’s picture

solideogloria CreditAttribution: solideogloria commented
Category: Bug report » Task
Status: Needs work » Needs review
FileSize
search_api_override-coding-standards-3039493-7.patch4.38 KB

I just manually made the changes, along with some that were missed. I figured that would be faster.

  • vuil committed 0ca444e on 7.x-1.x authored by solideogloria 
    Issue #3039493 by RoshniPatel.addweb, solideogloria, vuil, DamienMcKenna...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Needs review » Fixed

Committed! Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.