Problem/Motivation

Remove all the occurrence of drupal_set_message() is deprecated

Proposed resolution

Drupal 8.5.x has introduced a new messenger service.

I replaced drupal_set_message() with Drupal Messenger service.

CommentFileSizeAuthor
#7 remove_drupal_set_message-2.patch4 KBNaheemSays
#6 remove_drupal_set_message.patch4.01 KBNaheemSays
#5 remove_drupal_set_message.patch3.99 KBNaheemSays
#2 remove_deprecated_function_drupal_set_message-3040194-2.patch10.63 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
FileSize
remove_deprecated_function_drupal_set_message-3040194-2.patch10.63 KB
Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/Form/PollDeleteForm.php
@@ -2,15 +2,56 @@
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function create(ContainerInterface $container) {
+    return new static(
+      $container->get('entity.repository'),
+      $container->get('entity_type.bundle.info'),
+      $container->get('datetime.time'),
+      $container->get('messenger')
+    );
+  }
+

all forms have the Messenger trait now, so we can just use $this->messenger() and remove all this.

NaheemSays’s picture

NaheemSays CreditAttribution: NaheemSays commented
Status: Needs work » Needs review
FileSize
remove_drupal_set_message.patch3.99 KB
NaheemSays’s picture

NaheemSays CreditAttribution: NaheemSays commented
FileSize
remove_drupal_set_message.patch4.01 KB
NaheemSays’s picture

NaheemSays CreditAttribution: NaheemSays commented
FileSize
remove_drupal_set_message-2.patch4 KB

Replaced an addMessage with an addError.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, straight-forward now.

  • Berdir committed d4375fe on 8.x-1.x authored by nbz 
    Issue #3040194 by nbz, Sergiu Stici: Remove deprecated function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.