Problem/Motivation

Pareview checklist:

https://pareview.sh/pareview/https-git.drupal.org-project-xmlsitemap.git...

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#35 3042673-add-drupal9-requirement.patch1.44 KBDave Reid
#33 3042673-fix-more-deprecations.patch12.08 KBDave Reid
#18 3042673-drupal-9-deprecated-code.patch61.59 KBDave Reid
#17 3042673-drupal-9-deprecated-code.patch61.93 KBDave Reid
#16 3042673-drupal-9-deprecated-code.patch51.57 KBDave Reid
#15 3042673-drupal-9-deprecated-code.patch43.51 KBDave Reid
#6 drupal_9_deprecated_code-3042673-6.patch35.79 KBSergiu Stici
#4 drupal_9_deprecated_code-3042673-4.patch35.79 KBSergiu Stici
#2 drupal_9_deprecated_code-3042673-2.patch34.59 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Arrow created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code-3042673-2.patch34.59 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042673-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Needs work » Needs review
FileSize
drupal_9_deprecated_code-3042673-4.patch35.79 KB

Corrected codesniffer.

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3042673-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Needs work » Needs review
FileSize
drupal_9_deprecated_code-3042673-6.patch35.79 KB

Corrected codesniffer.

Status: Needs review » Needs work

The last submitted patch, 6: drupal_9_deprecated_code-3042673-6.patch, failed testing. View results

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Title: Drupal 9 Deprecated Code Report » Drupal 9 Ready (Parent issue)
Status: Needs work » Active
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented

Separate the issue into different (various) issues because it is huge. Thank you.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Issue summary: View changes

Already update (and choose to use) the issue for D9 status ready.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Title: Drupal 9 Ready (Parent issue) » Drupal 9 Ready
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Active » Needs review
FileSize
3042673-drupal-9-deprecated-code.patch43.51 KB

Let's try a current version, some of the fixes have been done already.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
FileSize
3042673-drupal-9-deprecated-code.patch51.57 KB

Let's fix some more.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
FileSize
3042673-drupal-9-deprecated-code.patch61.93 KB

And more.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
FileSize
3042673-drupal-9-deprecated-code.patch61.59 KB

Try this again.

Dave Reid credited ChristianAdamski.

Dave Reid credited KarimB.

Dave Reid credited Nikhilesh Gupta.

Dave Reid credited Tolyan4ik.

Dave Reid credited kkalaskar.

Dave Reid credited thalles.

Dave Reid credited voleger.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Related issues: +#2752217: XmlSitemap has deprecated functions and coding style issues, +#3052903: Replace deprecated file_unmanaged_delete in XmlSitemapGenerator, +#2742031: Replace deprecated code

Dave Reid credited RajeevChoudhary.

Dave Reid credited Saphyel.

Dave Reid credited amateescu.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

  • Dave Reid committed 959c7b5 on 8.x-1.x 
    Issue #3042673 by Dave Reid, Sergiu Stici, ChristianAdamski, KarimB,...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
FileSize
3042673-fix-more-deprecations.patch12.08 KB

Fixing some more deprecations.

  • Dave Reid committed 345f519 on 8.x-1.x 
    Issue #3042673 by Dave Reid: Fixed more coding standards and deprecated...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
FileSize
3042673-add-drupal9-requirement.patch1.44 KB

And now the last step to enable the module to be turned on with Drupal 9.

  • Dave Reid committed fd9a979 on 8.x-1.x 
    Issue #3042673 by Dave Reid: Allow the module to be enabled on Drupal 9.
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs review » Fixed

I think this is now resolved. We have some remaining PHPunit tests to convert, but that doesn't prevent the module from working.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Parent issue: » #3004330: [META] Prepare module for Drupal 9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.