Drupal 9 Deprecated Code Report [#3042712]

Problem/Motivation

[COMMIT_HASH]

 ad4d4133cf589de2c934651ec5e56ec2d8edcfcc

[RESULTS_OUTPUT]

 ------ ------------------------------------------------
  Line   panelizer.post_update.php
 ------ ------------------------------------------------
  30     Call to deprecated function db_table_exists().
 ------ ------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------
  Line   panelizer_quickedit/tests/src/FunctionalJavascript/PanelizerQuickEditTest.php
 ------ -------------------------------------------------------------------------------------------------------------
  14     Class Drupal\Tests\panelizer_quickedit\FunctionalJavascript\PanelizerQuickEditTest extends deprecated class
         Drupal\FunctionalJavascriptTests\JavascriptTestBase.
  25     Call to method setUp() of deprecated class Drupal\Tests\BrowserTestBase.
  72     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  77     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  110    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  141    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
 ------ -------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Form/PanelizerWizardContextDeleteForm.php
 ------ ---------------------------------------------------
  48     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------------------------
  Line   src/Form/PanelizerWizardContextForm.php
 ------ ---------------------------------------------------------------------
  144    Call to deprecated method url() of class Drupal\Core\Form\FormBase.
 ------ ---------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------
  Line   src/Panelizer.php
 ------ -------------------------------------------------------------------------------------------
  321    Call to deprecated method isSubclassOf() of class Drupal\Core\Entity\EntityTypeInterface.
 ------ -------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------
  Line   src/Tests/Update/PanelizerLayoutIDUpdateTest.php
 ------ ------------------------------------------------------------------------------------------
  12     Class Drupal\panelizer\Tests\Update\PanelizerLayoutIDUpdateTest extends deprecated class
         Drupal\system\Tests\Update\UpdatePathTestBase.
 ------ ------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerAddDefaultLinkTest.php
 ------ ---------------------------------------------------------------------------------
  58     Call to deprecated method assertLink() of class Drupal\Tests\BrowserTestBase.
  64     Call to deprecated method assertNoLink() of class Drupal\Tests\BrowserTestBase.
 ------ ---------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerDefaultsTest.php
 ------ ----------------------------------------------------------------------------------------
  76     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  77     Call to deprecated method assertNoFieldByName() of class Drupal\Tests\BrowserTestBase.
  84     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  85     Call to deprecated method assertFieldByName() of class Drupal\Tests\BrowserTestBase.
  86     Call to deprecated method assertOption() of class Drupal\Tests\BrowserTestBase.
  87     Call to deprecated method assertOption() of class Drupal\Tests\BrowserTestBase.
 ------ ----------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerIpeTest.php
 ------ -----------------------------------------------------------------------------------
  102    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  107    Call to deprecated method getRawContent() of class Drupal\Tests\BrowserTestBase.
  122    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  149    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  154    Call to deprecated method getRawContent() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  221    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  223    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  276    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  278    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  332    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  334    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  366    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  371    Call to deprecated method getRawContent() of class Drupal\Tests\BrowserTestBase.
 ------ -----------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerNodeFunctionalTest.php
 ------ -----------------------------------------------------------------------------------------
  56     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  57     Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  58     Call to deprecated method assertField() of class Drupal\Tests\BrowserTestBase.
  62     Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  76     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  80     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  82     Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  83     Call to deprecated method assertField() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  91     Call to deprecated method assertFieldChecked() of class Drupal\Tests\BrowserTestBase.
  98     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  99     Call to deprecated method assertNoFieldChecked() of class Drupal\Tests\BrowserTestBase.
  103    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  110    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  111    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  113    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  115    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  119    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase.
  125    Call to deprecated method assertNoLinkByHref() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase.
  148    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  152    Call to deprecated method assertIdentical() of class Drupal\Tests\BrowserTestBase.
  159    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  160    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
 ------ -----------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerNodeTranslationsTest.php
 ------ -----------------------------------------------------------------------------------------
  75     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  76     Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  77     Call to deprecated method assertField() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  100    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  102    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  103    Call to deprecated method assertField() of class Drupal\Tests\BrowserTestBase.
  108    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  111    Call to deprecated method assertFieldChecked() of class Drupal\Tests\BrowserTestBase.
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  119    Call to deprecated method assertNoFieldChecked() of class Drupal\Tests\BrowserTestBase.
  123    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  130    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  131    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  133    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  135    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  139    Call to deprecated method assertNoRaw() of class Drupal\Tests\BrowserTestBase.
  145    Call to deprecated method assertNoLinkByHref() of class Drupal\Tests\BrowserTestBase.
  146    Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  180    Call to deprecated method assertIdentical() of class Drupal\Tests\BrowserTestBase.
  187    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  188    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  192    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  193    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
 ------ -----------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTermFunctionalTest.php
 ------ ------------------------------------------------------------------------------------
  66     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  90     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertIdentical() of class Drupal\Tests\BrowserTestBase.
  101    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  102    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
 ------ ------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerAddDefaultLinkTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------------
  78     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated function entity_get_form_display().
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated function entity_get_form_display().
  152    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  161    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  164    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  166    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  174    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  196    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  211    Call to deprecated function entity_get_display().
  230    Call to deprecated function entity_get_display().
 ------ ---------------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerDefaultsTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------
  78     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated function entity_get_form_display().
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated function entity_get_form_display().
  152    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  161    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  164    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  166    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  174    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  196    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  211    Call to deprecated function entity_get_display().
  230    Call to deprecated function entity_get_display().
 ------ ---------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerIpeTest)
 ------ ----------------------------------------------------------------------------------------------------------------------
  78     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated function entity_get_form_display().
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated function entity_get_form_display().
  152    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  161    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  164    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  166    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  174    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  196    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  211    Call to deprecated function entity_get_display().
  230    Call to deprecated function entity_get_display().
 ------ ----------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerNodeFunctionalTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------------
  78     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated function entity_get_form_display().
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated function entity_get_form_display().
  152    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  161    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  164    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  166    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  174    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  196    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  211    Call to deprecated function entity_get_display().
  230    Call to deprecated function entity_get_display().
 ------ ---------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerNodeTranslationsTest)
 ------ -----------------------------------------------------------------------------------------------------------------------------------
  78     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  88     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  96     Call to deprecated function entity_get_form_display().
  118    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  124    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  126    Call to deprecated function entity_get_form_display().
  152    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  161    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  164    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  166    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  169    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  171    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  174    Call to deprecated method assertUrl() of class Drupal\Tests\BrowserTestBase.
  176    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  194    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  196    Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  211    Call to deprecated function entity_get_display().
  230    Call to deprecated function entity_get_display().
 ------ -----------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerUserFunctionalTest.php
 ------ ------------------------------------------------------------------------------------
  61     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  67     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  94     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  100    Call to deprecated method assertIdentical() of class Drupal\Tests\BrowserTestBase.
  107    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
  108    Call to deprecated method assertText() of class Drupal\Tests\BrowserTestBase.
 ------ ------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------
  Line   tests/src/FunctionalJavascript/PanelizerIntegrationTest.php
 ------ -------------------------------------------------------------------------------
  15     Usage of deprecated trait Drupal\simpletest\ContentTypeCreationTrait in class
         Drupal\Tests\panelizer\FunctionalJavascript\PanelizerIntegrationTest.
 ------ -------------------------------------------------------------------------------


 [ERROR] Found 198 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#12	drupal_9_deprecated_code-3042712-12.patch	5.38 KB	pranit84
#12	8.x-5.x: PHP 7.1 & MySQL 5.6, D8.8 49 pass, 1 fail PHP 7.2 & MySQL 5.5, D8.8 49 pass, 1 fail PHP 7.1 & MySQL 5.5, D8.8 53 pass PHP 7.1 & MySQL 5.6, D8.8 53 pass PHP 7.2 & MySQL 5.5, D8.8 53 pass PHP 7.1 & PostgreSQL 9.1, D8.9 53 pass
#9	drupal_9_deprecated_code-3042712-9.patch	5.14 KB	pranit84
#9	8.x-5.x: PHP 7.1 & PostgreSQL 9.1, D8.8 52 pass PHP 7.2 & MySQL 5.5, D8.8 52 pass PHP 7.2 & MySQL 5.5, D8.8 49 pass, 1 fail
#8	drupal_9_deprecated_code-3042712-8.patch	37.62 KB	sandboxpl
#8	8.x-5.x: PHP 7.1 & PostgreSQL 9.1, D8.8 Patch Failed to Apply
#3	drupal_9_deprecated_code-3042712-3.patch	37.01 KB	Sergiu Stici
#3	8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 43 pass, 7 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 March 2019 at 20:10

Adrianm6254 created an issue. See original summary.

Comment #2

joelpittet

English

Vancouver

CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented 10 April 2019 at 18:58

Issue tags:

+Novice, +Seattle2019

Tagging for DrupalCon Seattle Friday contribution sprint.

File	Size
drupal_9_deprecated_code-3042712-3.patch	37.01 KB
8.x-4.x: PHP 7.2 & MySQL 5.5, D8.8 43 pass, 7 fail

Comment #4

maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commented 20 April 2019 at 13:48

Issue summary:

View changes

Comment #5

joelpittet

English

Vancouver

CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented 24 April 2019 at 18:14

It may be worth breaking this up into smaller chunks. I'd remove the tempstore changes and move that to a separate issue (if it isn't already)

Comment #6

DrupalZone CreditAttribution: DrupalZone as a volunteer commented 21 May 2019 at 13:00

Status:

Needs review

» Needs work

Showing following errors after applying patch #3

php drupal-check.phar modules/panelizer/

53/53 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------------------------------------
Line src/Plugin/PanelsPattern/PanelizerPattern.php
------ ------------------------------------------------------------------------------------------------
Class Drupal\panels\Plugin\PanelsPattern\DefaultPattern not found and could not be autoloaded.
------ ------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------
Line src/Plugin/PanelsStorage/PanelizerDefaultPanelsStorage.php
------ --------------------------------------------------------------------------------------
Class Drupal\panels\Storage\PanelsStorageBase not found and could not be autoloaded.
------ --------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------
Line src/Plugin/PanelsStorage/PanelizerFieldPanelsStorage.php
------ --------------------------------------------------------------------------------------
Class Drupal\panels\Storage\PanelsStorageBase not found and could not be autoloaded.
------ --------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------
Line src/Tests/Update/PanelizerLayoutIDUpdateTest.php
------ -----------------------------------------------------------------------------------
32 Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
35 Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
38 Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
------ -----------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------
Line tests/src/Functional/PanelizerIpeTest.php
------ ----------------------------------------------------------------------------------
107 Call to deprecated method getRawContent() of class Drupal\Tests\BrowserTestBase.
154 Call to deprecated method getRawContent() of class Drupal\Tests\BrowserTestBase.
------ ----------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------------
Line tests/src/FunctionalJavascript/PanelizerIntegrationTest.php
------ -------------------------------------------------------------------------------------------------------------
Class Drupal\Tests\panels_ipe\FunctionalJavascript\PanelsIPETestBase not found and could not be autoloaded.
------ -------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------
Line tests/src/Unit/PanelizerDefaultPanelsStorageTest.php
------ --------------------------------------------------------------------------------------
59 Class Drupal\panels\Storage\PanelsStorageBase not found and could not be autoloaded.
------ --------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------
Line tests/src/Unit/PanelizerFieldPanelsStorageTest.php
------ --------------------------------------------------------------------------------------
59 Class Drupal\panels\Storage\PanelsStorageBase not found and could not be autoloaded.
------ --------------------------------------------------------------------------------------

[ERROR] Found 11 errors

Comment #7

tatarbj

Hungarian

Brussels

CreditAttribution: tatarbj at Petend commented 2 June 2019 at 13:19

Issue tags:

+DC19PL

sandboxpl and shumer are sprinting on this issue at Drupal Camp Poland 2019 Contribution time.

Comment #8

sandboxpl

Polish

Poland 🇵🇱

CreditAttribution: sandboxpl at Dropsolid commented 2 June 2019 at 13:47

Status:

Needs work

» Needs review

File	Size
drupal_9_deprecated_code-3042712-8.patch	37.62 KB
8.x-5.x: PHP 7.1 & PostgreSQL 9.1, D8.8 Patch Failed to Apply

We've pulled 5.x version of the module , applied #3 patch and executed drupal-check against it, the result was following:

$ drupal-check panelizer/
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 38 MB of memory.


To avoid this issue, allow to use more memory with the --memory-limit option.
 17/53 [▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░]  32%PHP Fatal error:  Declaration of Drupal\panelizer\Plugin\PanelsPattern\PanelizerPattern::getDefaultContexts(Drupal\user\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) must be compatible with Drupal\panels\Plugin\PanelsPattern\DefaultPattern::getDefaultContexts(Drupal\Core\TempStore\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) in /home/drupalranger/projects/varbase/docroot/modules/contrib/panelizer/src/Plugin/PanelsPattern/PanelizerPattern.php on line 14

Fatal error: Declaration of Drupal\panelizer\Plugin\PanelsPattern\PanelizerPattern::getDefaultContexts(Drupal\user\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) must be compatible with Drupal\panels\Plugin\PanelsPattern\DefaultPattern::getDefaultContexts(Drupal\Core\TempStore\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) in /home/drupalranger/projects/varbase/docroot/modules/contrib/panelizer/src/Plugin/PanelsPattern/PanelizerPattern.php on line 14

We've fixed outstanding error in PanelizerPattern plugin class, then executed drupal-check again, and we've got success:

$ drupal-check panelizer/
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 38 MB of memory.


To avoid this issue, allow to use more memory with the --memory-limit option.
 53/53 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors

New patch in attachment

Comment #9

pranit84

Hindi

Faridabad (India)

CreditAttribution: pranit84 as a volunteer commented 14 August 2019 at 16:31

File	Size
drupal_9_deprecated_code-3042712-9.patch	5.14 KB
8.x-5.x: PHP 7.1 & PostgreSQL 9.1, D8.8 52 pass PHP 7.2 & MySQL 5.5, D8.8 52 pass PHP 7.2 & MySQL 5.5, D8.8 49 pass, 1 fail

Comment #10

pranit84

Hindi

Faridabad (India)

CreditAttribution: pranit84 as a volunteer commented 16 August 2019 at 10:42

Created patch from scratch and check it with drupal-check.

➜ contrib git:(8.8.x) ✗ drupal-check panelizer
56/56 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Comment #11

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 at Acquia commented 19 August 2019 at 13:37

Status:

Needs review

» Needs work

+++ b/src/Form/PanelizerWizardContextForm.php
@@ -145,7 +145,7 @@ class PanelizerWizardContextForm extends ManageContext {
+    $content['submit']['#attached']['drupalSettings']['ajax'][$content['submit']['#id']]['url'] = \Drupal\Core\Url::fromUri($this->getContextAddRoute($cached_values), ['query' => [FormBuilderInterface::AJAX_FORM_REQUEST => TRUE]]);

class fully namespace is not used instead add it to top.

+++ b/tests/src/Functional/PanelizerTestTrait.php
@@ -93,7 +93,7 @@ trait PanelizerTestTrait {
+    \Drupal::service('entity_display.repository')->getFormDisplay('node', $content_type)

are you sure this is correct replacement of deprecated method as EntityDisplayRepository doesn't contain

Comment #12

pranit84

Hindi

Faridabad (India)

CreditAttribution: pranit84 as a volunteer commented 28 August 2019 at 06:08

File	Size
drupal_9_deprecated_code-3042712-12.patch	5.38 KB
8.x-5.x: PHP 7.1 & MySQL 5.6, D8.8 49 pass, 1 fail PHP 7.2 & MySQL 5.5, D8.8 49 pass, 1 fail PHP 7.1 & MySQL 5.5, D8.8 53 pass PHP 7.1 & MySQL 5.6, D8.8 53 pass PHP 7.2 & MySQL 5.5, D8.8 53 pass PHP 7.1 & PostgreSQL 9.1, D8.9 53 pass

1. class is added to the top and used Url::fromUri();
2. This is correct replacement.

Comment #13

pranit84

Hindi

Faridabad (India)

CreditAttribution: pranit84 as a volunteer commented 30 August 2019 at 12:05

This test case failure has nothing to do with this patch, it was failing in the drupal without this patch as well. And this patch is meant to fix the deprecated code only.

Comment #14

pranit84

Hindi

Faridabad (India)

CreditAttribution: pranit84 as a volunteer commented 6 September 2019 at 16:09

All the tests are now passing after the module got an update.

Comment #15

amitgoyal CreditAttribution: amitgoyal commented 10 September 2019 at 08:47

Status:

Needs work

» Reviewed & tested by the community

Before applying the patch in #12, I was getting below 20 errors,

➜  d9 git:(8.8.x) ✗ ./vendor/bin/drupal-check -d modules/contrib/panelizer


 57/57 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------
  Line   panelizer.post_update.php
 ------ --------------------------------------------------------------------------
  30     Call to deprecated function db_table_exists():
         in drupal:8.0.0 and will be removed from drupal:9.0.0. Instead,
         get a database connection injected into your service from the container,
         get its schema driver, and call tableExists() on it. For example,
 ------ --------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/PanelizerWizardContextDeleteForm.php
 ------ ----------------------------------------------------------------------
  48     Call to deprecated function drupal_set_message():
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ---------------------------------------------------------------------
  Line   src/Form/PanelizerWizardContextForm.php
 ------ ---------------------------------------------------------------------
  148    Call to deprecated method url() of class Drupal\Core\Form\FormBase:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Url::fromUri() instead.
 ------ ---------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------
  Line   src/Panelizer.php
 ------ -------------------------------------------------------------------------------------------
  320    Call to deprecated method isSubclassOf() of class Drupal\Core\Entity\EntityTypeInterface:
         in Drupal 8.3.0 and will be removed before Drupal 9.0.0.
         Use Drupal\Core\Entity\EntityTypeInterface::entityClassImplements()
         instead.
 ------ -------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerAddDefaultLinkTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------------
  96     Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  126    Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  211    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
  230    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ ---------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerIpeTest)
 ------ ----------------------------------------------------------------------------------------------------------------------
  96     Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  126    Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  211    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
  230    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ ----------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerNodeFunctionalTest)
 ------ ---------------------------------------------------------------------------------------------------------------------------------
  96     Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  126    Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  211    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
  230    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ ---------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/PanelizerTestTrait.php (in context of class Drupal\Tests\panelizer\Functional\PanelizerNodeTranslationsTest)
 ------ -----------------------------------------------------------------------------------------------------------------------------------
  96     Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  126    Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  211    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
  230    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ -----------------------------------------------------------------------------------------------------------------------------------


 [ERROR] Found 20 errors

But after applying the patch, there are no deprecations,

➜  d9 git:(8.8.x) ✗ ./vendor/bin/drupal-check -d modules/contrib/panelizer


 57/57 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

Thanks everyone!

Comment #16

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 30 December 2019 at 14:25

Adjusting credits for commit.

Comment #17

30 December 2019 at 14:26

phenaproxima committed c40ce04 on 8.x-5.x

Issue #3042712 by pranit84, sandboxpl, Sergiu Stici, DrupalZone,...

Comment #18

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 30 December 2019 at 14:26

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed to 8.x-5.x. Thanks!

Comment #19

13 January 2020 at 14:29

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community