Drupal 9 Deprecated Code Report for Login Security module [#3042720]

Problem/Motivation

drupal-check results on commit hash: 734ed5d241416246f54f7e7f857c97a06fc249a8

 ------ ----------------------------------------------------------------------------------
  Line   login_security.module
 ------ ----------------------------------------------------------------------------------
  125    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  125    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  214    Call to deprecated function drupal_get_messages().
  240    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  240    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  242    Call to deprecated function drupal_set_message().
  259    Call to deprecated function drupal_set_message().
  259    Call to deprecated function format_date().
  264    Call to deprecated function drupal_set_message().
  264    Call to deprecated function format_date().
  283    Call to deprecated function db_delete().
  289    Call to deprecated function db_delete().
  317    Call to deprecated function db_delete().
  333    Call to deprecated function db_insert().
  358    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  358    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  384    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  384    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  411    Call to deprecated function format_date().
  460    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  460    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  461    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  461    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  465    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  465    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  466    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  466    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
 ------ ----------------------------------------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Form/LoginSecurityAdminSettings.php
 ------ ---------------------------------------------------
  241    Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ----------------------------------------------------------------------------------
  Line   src/Tests/LoginSecurityInterfaceTest.php
 ------ ----------------------------------------------------------------------------------
  40     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  40     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
 ------ ----------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------
  Line   src/Tests/LoginSecuritySoftBlockTest.php
 ------ ----------------------------------------------------------------------------------
  24     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  24     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
 ------ ----------------------------------------------------------------------------------

 ------ -----------------------------------------
  Line   src/Tests/LoginSecurityTestBase.php
 ------ -----------------------------------------
  22     Call to deprecated function db_query().
  23     Call to deprecated function db_query().
 ------ -----------------------------------------

 ------ ----------------------------------------------------------------------------------
  Line   src/Tests/LoginSecurityUserBlockingTest.php
 ------ ----------------------------------------------------------------------------------
  50     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  50     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  64     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  64     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  105    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  105    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  106    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  106    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  150    Call to deprecated function db_truncate().
  170    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  170    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  171    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  171    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  217    Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  217    Call to deprecated method getUsername() of class Drupal\user\Entity\User.
  217    Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
 ------ ----------------------------------------------------------------------------------


 [ERROR] Found 50 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#21	3042720-9_0.patch	23.49 KB	jcnventura
#21	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7 & MySQL 5.5, D8.9.1 9 pass
#19	interdiff_14-16.txt	5.25 KB	satyaki_dutta
#16	drupal_9_3042720-16.patch	16.03 KB	satyaki_dutta
#16	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Patch Failed to Apply PHP 7.4 & MySQL 5.7, D8.9 Patch Failed to Apply
#14	drupal_9_3042720-14.patch	16.58 KB	satyaki_dutta
#14	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Patch Failed to Apply
#9	3042720-9.patch	23.49 KB	lhridley
#9	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.3 & MySQL 5.5, D8.9 9 pass
#9	interdiff.txt	8.26 KB	lhridley
#6	interdiff_5-6.txt	1.44 KB	driverok
#6	drupal_9_deprecated_code-3042720-6.patch	17.79 KB	driverok
#6	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.3 & MySQL 5.6, D8.9 9 pass
#5	drupal_9_deprecated_code-3042720-5.patch	16.15 KB	nikolas.tatianenko
#5	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue.
#5	interdiff-3042720-4-5-do-not-test.diff	615 bytes	nikolas.tatianenko
#5
#4	interdiff-3042720-2-4-do-not-test.diff	309 bytes	Daniel Korte
#4
#4	drupal_9_deprecated_code-3042720-4.patch	15.71 KB	Daniel Korte
#4	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue.
#2	drupal_9_deprecated_code-3042720-2.patch	15.35 KB	Sergiu Stici
#2	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.8 17 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 March 2019 at 20:31

Arrow created an issue. See original summary.

File	Size
drupal_9_deprecated_code-3042720-2.patch	15.35 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.8 17 pass

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 4 February 2020 at 16:00

Title:

Drupal 9 Deprecated Code Report

» Drupal 9 Deprecated Code Report for Login Security module

File	Size
drupal_9_deprecated_code-3042720-4.patch	15.71 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue.
interdiff-3042720-2-4-do-not-test.diff	309 bytes

Comment #5

nikolas.tatianenko CreditAttribution: nikolas.tatianenko as a volunteer and at EPAM Systems commented 21 May 2020 at 00:01

File	Size
interdiff-3042720-4-5-do-not-test.diff	615 bytes

drupal_9_deprecated_code-3042720-5.patch	16.15 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue.

Hi all,
I've found 2 more deprecation issues.

FILENAME LINE ERROR
web/modules/contrib/login_security/src/Tests/LoginSecurityTestBase.php 10 Class Drupal\login_security\Tests\LoginSecurityTestBase extends deprecated class Drupal\simpletest\WebTestBase. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, use Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340. Replacement available from drupal:8.6.0.
web/modules/contrib/login_security/src/Tests/LoginSecurityTestBase.php 19 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, use Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340. Replacement available from drupal:8.6.0.

========
Rector review result

24/24 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

========
Drupal-check review result

8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors
=========
Upgrade status review result = no errors
=========
Tested at Drupal 8.8 and Drupal 9-beta3

Comment #6

driverok CreditAttribution: driverok at EPAM Systems commented 22 May 2020 at 13:58

File	Size
drupal_9_deprecated_code-3042720-6.patch	17.79 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.3 & MySQL 5.6, D8.9 9 pass
interdiff_5-6.txt	1.44 KB

Checked #5.

Still some issues with tests and module schema.

Updated #5 with fixes for tests and schema.

Now tests look good:
Testing modules/login_security/
......... 9 / 9 (100%)

Time: 11.92 minutes, Memory: 6.00 MB

OK (9 tests, 233 assertions)

Please check.

Comment #7

nikolas.tatianenko CreditAttribution: nikolas.tatianenko as a volunteer and at EPAM Systems commented 23 May 2020 at 12:34

Issue tags:

+epam-contrib, +Drupal 9 porting weekend

Comment #8

mradcliffe

he/him

English

CreditAttribution: mradcliffe at Kosada commented 23 May 2020 at 22:53

Status:

Needs review

» Needs work

Great work on the patch. Things look accurate. However

+++ b/src/Form/LoginSecurityAdminSettings.php
--- a/src/Tests/LoginSecurityEmailTest.php
+++ b/src/Tests/LoginSecurityEmailTest.php

+++ b/src/Tests/LoginSecurityEmailTest.php
--- a/src/Tests/LoginSecurityInterfaceTest.php
+++ b/src/Tests/LoginSecurityInterfaceTest.php

+++ b/src/Tests/LoginSecurityInterfaceTest.php
--- a/src/Tests/LoginSecuritySoftBlockTest.php
+++ b/src/Tests/LoginSecuritySoftBlockTest.php

+++ b/src/Tests/LoginSecuritySoftBlockTest.php
--- a/src/Tests/LoginSecurityTestBase.php
+++ b/src/Tests/LoginSecurityTestBase.php

+++ b/src/Tests/LoginSecurityTestBase.php
--- a/src/Tests/LoginSecurityUserBlockingTest.php
+++ b/src/Tests/LoginSecurityUserBlockingTest.php

Functional tests extending BrowserTestBase should be moved underneath the tests/src/Functional directory per PHPUNit file structure, namespace and required metadata.

So the directory and the namespace in the files need to be updated.

Comment #9

lhridley CreditAttribution: lhridley as a volunteer and commented 4 June 2020 at 20:13

File	Size
interdiff.txt	8.26 KB
3042720-9.patch	23.49 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.3 & MySQL 5.5, D8.9 9 pass

Rerolled patch after moving tests to appropriate directory and adjusting namespacing.

Also reran for coding standards and made the latest corrections, included in this patch.

Interdiff is attached also.

Comment #10

lhridley CreditAttribution: lhridley as a volunteer and commented 4 June 2020 at 20:13

Status:

Needs work

» Needs review

Comment #11

minakshiPh CreditAttribution: minakshiPh at TATA Consultancy Services for Pfizer, Inc. commented 20 June 2020 at 07:40

Status:

Needs review

» Needs work

Hi @Ihridley,

I have tested the patch in #9 and it shows following error while applying on the local; so marking to needs work.

drupal-8.8.8/modules/contrib/login_security (8.x-1.x) $ git apply --check 3042720-9_0.patch
error: tests/src/Functional/LoginSecurityEmailTest.php: already exists in working directory
error: tests/src/Functional/LoginSecurityInterfaceTest.php: already exists in working directory
error: tests/src/Functional/LoginSecuritySoftBlockTest.php: already exists in working directory
error: tests/src/Functional/LoginSecurityTestBase.php: already exists in working directory
error: tests/src/Functional/LoginSecurityUserBlockingTest.php: already exists in working directory

drupal-8.8.8/modules/contrib/login_security (8.x-1.x) $ git apply -v 3042720-9_0.patch
Checking patch config/schema/login_security.schema.yml...
Checking patch login_security.info.yml...
Checking patch login_security.module...
Checking patch src/Form/LoginSecurityAdminSettings.php...
Checking patch src/Tests/LoginSecurityEmailTest.php => tests/src/Functional/LoginSecurityEmailTest.php...
error: tests/src/Functional/LoginSecurityEmailTest.php: already exists in working directory
Checking patch src/Tests/LoginSecurityInterfaceTest.php => tests/src/Functional/LoginSecurityInterfaceTest.php...
error: tests/src/Functional/LoginSecurityInterfaceTest.php: already exists in working directory
Checking patch src/Tests/LoginSecuritySoftBlockTest.php => tests/src/Functional/LoginSecuritySoftBlockTest.php...
error: tests/src/Functional/LoginSecuritySoftBlockTest.php: already exists in working directory
Checking patch src/Tests/LoginSecurityTestBase.php => tests/src/Functional/LoginSecurityTestBase.php...
error: tests/src/Functional/LoginSecurityTestBase.php: already exists in working directory
Checking patch src/Tests/LoginSecurityUserBlockingTest.php => tests/src/Functional/LoginSecurityUserBlockingTest.php...
error: tests/src/Functional/LoginSecurityUserBlockingTest.php: already exists in working directory

drupal-8.8.8/modules/contrib/login_security (8.x-1.x) $

Comment #12

divyesh19

his/him/he

English

CreditAttribution: divyesh19 at TATA Consultancy Services for Pfizer, Inc. commented 20 June 2020 at 10:08

Status:

Needs work

» Reviewed & tested by the community

Patch #9 looks good and applies cleanly.
Able to install module on D8.8.7 as well as D9 after applying the patch.

Comment #13

orlando.thoeny

Switzerland 🇨🇭

CreditAttribution: orlando.thoeny at Namics for Namics commented 29 July 2020 at 17:14

#9 works for me using Core 9.0.2 & dev 734ed5d of this module.

This patch also includes https://www.drupal.org/project/login_security/issues/3134020

Comment #14

satyaki_dutta CreditAttribution: satyaki_dutta commented 11 August 2020 at 09:59

File	Size
drupal_9_3042720-14.patch	16.58 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Patch Failed to Apply

Please review the patch made on report from upgrade status module.

Comment #15

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 11 August 2020 at 10:32

@satyaki_dutta: Given there was already a patch that had reached RTBC, were there additional changes necessary?

Comment #16

satyaki_dutta CreditAttribution: satyaki_dutta commented 11 August 2020 at 11:49

File	Size
drupal_9_3042720-16.patch	16.03 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Patch Failed to Apply PHP 7.4 & MySQL 5.7, D8.9 Patch Failed to Apply

1 file was hidden/shown/deleted

File	Size
3042720-9.patch	23.49 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7.3 & MySQL 5.5, D8.9 9 pass

@DamienMckenna the previous uploaded patch had some issues so had to upload again

Comment #17

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 11 August 2020 at 14:18

Status:

Reviewed & tested by the community

» Needs review

Could you please describe the issues, and possibly provide an interdiff? Thank you.

Setting the status to "needs review" as the new patch needs to be reviewed.

Comment #18

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 11 August 2020 at 14:20

I set the tests to run against PHP 7.4 as the current 5.6 isn't supported by core (see #3164545).

Comment #19

satyaki_dutta CreditAttribution: satyaki_dutta commented 19 August 2020 at 11:39

File	Size
interdiff_14-16.txt	5.25 KB

The issue with my previous patch was that the patch was given wrong for the files.

Comment #20

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 31 August 2020 at 10:30

+++ b/login_security/login_security.module
@@ -211,7 +213,7 @@ function login_security_validate(array $form, FormStateInterface $form_state) {
+        \Drupal\Core\Messenger\MessengerInterface::messagesByType('error', TRUE);

@@ -237,9 +239,9 @@ function login_security_validate(array $form, FormStateInterface $form_state) {
+          MessengerInterface::addMessage($message, 'warning', TRUE);

There's something really wrong going on here... #9 is still the one to use.

Comment #21

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 31 August 2020 at 10:33

Status:

Needs review

» Reviewed & tested by the community

File	Size
3042720-9_0.patch	23.49 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.9 Composer error. Unable to continue. PHP 7 & MySQL 5.5, D8.9.1 9 pass

Re-uploading #9, and setting back the RTBC status from #12 and #13.

Disregard #14 and #16, please. I think no credit should be assigned.

Comment #22

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 5 October 2020 at 14:05

Great to see this tested. Login Security is one of the 9 top 200 projects on drupal.org that is not yet Drupal 9 compatible. 🤞

Comment #23

jribeiro CreditAttribution: jribeiro for Pfizer, Inc. commented 6 October 2020 at 13:25

Status:

Reviewed & tested by the community

» Fixed

Thanks everyone, great work!

Committed and cut the first semantic versioning release 2.0.0.

Comment #24

jribeiro CreditAttribution: jribeiro for Pfizer, Inc. commented 7 October 2020 at 18:23

Have you seen this? https://www.drupal.org/project/login_security/issues/3175408

Comment #25

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 7 October 2020 at 21:31

Never saw #24 before. I've been installing this module on a few D9 sites, but the config used probably didn't trigger that. Now that the module can easily be installed in D9, you'll be able to uncover all the D9 incompatibilities that can't be discovered by automated tools.