Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/fontyourface 4e7ac385ec74ca1506df727039607a369c02e9cc
source : http://cgit.drupalcode.org/fontyourface 


 ------ ------------------------------------------------------------ 
  Line   fontyourface.module                                         
 ------ ------------------------------------------------------------ 
  169    Call to deprecated method l() of class Drupal.              
  213    Call to deprecated method l() of class Drupal.              
  362    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   modules/adobe_edge_fonts/adobe_edge_fonts.module   
 ------ --------------------------------------------------- 
  28     Call to deprecated function drupal_set_message().  
  75     Call to deprecated function drupal_set_message().  
  118    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/fontscom_api/fontscom_api.module           
 ------ --------------------------------------------------- 
  40     Call to deprecated function drupal_set_message().  
  125    Call to deprecated function drupal_set_message().  
  256    Call to deprecated function drupal_set_message().  
  260    Call to deprecated function drupal_set_message().  
  304    Call to deprecated function drupal_set_message().  
  368    Call to deprecated function drupal_set_message().  
  399    Call to deprecated function drupal_set_message().  
  427    Call to deprecated function drupal_set_message().  
  449    Call to deprecated function drupal_set_message().  
  483    Call to deprecated function drupal_set_message().  
  508    Call to deprecated function drupal_set_message().  
  527    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/fontsquirrel_api/fontsquirrel_api.module   
 ------ --------------------------------------------------- 
  30     Call to deprecated function drupal_set_message().  
  47     Call to deprecated function drupal_realpath().     
  52     Call to deprecated function drupal_realpath().     
  205    Call to deprecated function drupal_set_message().  
  223    Call to deprecated function drupal_set_message().  
  246    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/google_fonts_api/google_fonts_api.module   
 ------ --------------------------------------------------- 
  28     Call to deprecated function drupal_set_message().  
  132    Call to deprecated function drupal_set_message().  
  155    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   modules/local_fonts/local_fonts.module                      
 ------ ------------------------------------------------------------ 
  84     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   modules/local_fonts/src/Form/LocalFontConfigEntityDeleteForm.php  
 ------ ------------------------------------------------------------------ 
  41     Call to deprecated function drupal_set_message().                 
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   modules/local_fonts/src/Form/LocalFontConfigEntityForm.php  
 ------ ------------------------------------------------------------ 
  138    Call to deprecated function drupal_set_message().           
  144    Call to deprecated function drupal_set_message().           
  148    Call to deprecated method urlInfo() of class                
         Drupal\Core\Entity\EntityInterface.                         
 ------ ------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   modules/typekit_api/typekit_api.module             
 ------ --------------------------------------------------- 
  32     Call to deprecated function drupal_set_message().  
  61     Call to deprecated function drupal_set_message().  
  102    Call to deprecated function drupal_set_message().  
  133    Call to deprecated function drupal_set_message().  
  136    Call to deprecated function drupal_set_message().  
  156    Call to deprecated function drupal_set_message().  
  180    Call to deprecated function drupal_set_message().  
  206    Call to deprecated function drupal_set_message().  
  249    Call to deprecated method strtolower() of class    
         Drupal\Component\Utility\Unicode.                  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Controller/FontYourFaceController.php          
 ------ --------------------------------------------------- 
  26     Call to deprecated method l() of class Drupal.     
  32     Call to deprecated function drupal_set_message().  
  45     Call to deprecated function drupal_set_message().  
  61     Call to deprecated method l() of class Drupal.     
  67     Call to deprecated function drupal_set_message().  
  80     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Entity/Font.php                                         
 ------ ------------------------------------------------------------ 
  182    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Entity/FontDisplay.php                                  
 ------ ------------------------------------------------------------ 
  175    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   src/FontListBuilder.php                                           
 ------ ------------------------------------------------------------------ 
  16     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait  
         in class Drupalontyourface\FontListBuilder.                     
  33     Call to deprecated method l() of class                            
         Drupalontyourface\FontListBuilder.                              
  35     Call to deprecated method urlInfo() of class                      
         Drupal\Core\Entity\EntityInterface.                               
  56     Call to deprecated method urlInfo() of class                      
         Drupal\Core\Entity\EntityInterface.                               
 ------ ------------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   src/Form/FontDisplayDeleteForm.php                 
 ------ --------------------------------------------------- 
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontDisplayForm.php                       
 ------ --------------------------------------------------- 
  47     Call to deprecated function drupal_set_message().  
  174    Call to deprecated function drupal_set_message().  
  180    Call to deprecated function drupal_set_message().  
  186    Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontForm.php                              
 ------ --------------------------------------------------- 
  35     Call to deprecated function drupal_set_message().  
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontSettingsForm.php                      
 ------ --------------------------------------------------- 
  159    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   tests/websafe_fonts_test/websafe_fonts_test.module  
 ------ ---------------------------------------------------- 
  57     Call to deprecated function drupal_set_message().   
 ------ ---------------------------------------------------- 

 [ERROR] Found 62 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#22 3042792-22.patch17.17 KBNeslee Canil Pinto
#20 3042792-20.patch15.09 KBSuresh Prabhu Parkala
#19 3042792-19.patch15.07 KBSuresh Prabhu Parkala
#16 3042792-16.patch15.01 KBSuresh Prabhu Parkala
#10 interdiff_8_9.diff3.31 KBnikolas.tatianenko
#10 fontyourface-3042792-9.patch25.14 KBnikolas.tatianenko
#9 fontyourface-3042792-8.patch21.59 KBdouggreen
#8 fontyourface-3042792-7.patch21.58 KBdouggreen
#5 fontyourface-3082934-5.patch17.5 KBdouggreen
#2 drupal_9_deprecated_code-3042792-2.patch30.38 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdwayne created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code-3042792-2.patch30.38 KB

Here is the patch, please review.

BTMash’s picture

BTMash CreditAttribution: BTMash as a volunteer commented
Status: Needs review » Postponed

Sorry for not responding to this sooner. I'm finally getting back to maintaining this module.

To be really frank, I'm going to postpone this. I appreciate the patch but removing the deprecated code means its not going to work with older versions of Drupal 8.x. There will be a 9.x branch where all the deprecated code will get removed.

ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer and at Four Kitchens commented
Status: Postponed » Closed (outdated)

@sergiu-stici I would like to apologize to you from the whole Drupal community and say that your hard work here was very clearly overlooked and a patch that clearly had a lot of good work in it was not committed. This module could have been ready a year ago but now others had to repeat your work in other issues.

Looking at the other open issues of this module and recent commits of this project this issue is now outdated and will never be committed. I am going to mark it as closed (outdated). I hope this does not dissuade you from future contributions.

cc: @BTMash

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented
FileSize
fontyourface-3082934-5.patch17.5 KB

I need a clean patch to prepare For Drupal 9 and couldn't find al the issues that @ccjmartin mentioned above. I only found [#3082934. The attached patch is my first pass based on drupal-check.

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented
Status: Closed (outdated) » Needs review

Reopening in the hopes that the module maintainer will reconsider. The composer.json changes make it so that this module would require Drupal 8.7.7 or higher. Sites should be running that version because anything below it is not supported with security updates.

Status: Needs review » Needs work

The last submitted patch, 5: fontyourface-3082934-5.patch, failed testing. View results

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented
FileSize
fontyourface-3042792-7.patch21.58 KB

Updated patch includes composer and core_version_requirement updates.

douggreen’s picture

douggreen CreditAttribution: douggreen as a volunteer commented
FileSize
fontyourface-3042792-8.patch21.59 KB

Updated patch fixes core_version_requirment to 8.7.7 instead of 8.7.

nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
Issue tags: +Drupal 9 porting weekend, +epam-contrib
FileSize
fontyourface-3042792-9.patch25.14 KB
interdiff_8_9.diff3.31 KB

Additional improvements. No known errors
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

138/138 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, Open Y, Drupal Ukraine Community for Open Y, Drupal Ukraine Community commented

@nikolas.tatianenko - any plans to push this code to dev?
I'd like to test it for dgo.to/openy readiness asap
Thank you

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, Open Y, Drupal Ukraine Community for Open Y, Drupal Ukraine Community commented
Status: Needs work » Reviewed & tested by the community

The last submitted patch, 9: fontyourface-3042792-8.patch, failed testing. View results

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Needs work
Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Assigned: Unassigned » Suresh Prabhu Parkala
Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3042792-16.patch15.01 KB

Re-rolled patch. Please review!

Status: Needs review » Needs work

The last submitted patch, 16: 3042792-16.patch, failed testing. View results

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Issue tags: +Needs reroll 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15371  100 15371    0     0  12103      0  0:00:01  0:00:01 --:--:-- 12103
error: patch failed: fontyourface.module:405
error: fontyourface.module: patch does not apply
error: patch failed: modules/fontscom_api/fontscom_api.module:158
error: modules/fontscom_api/fontscom_api.module: patch does not apply
error: patch failed: modules/local_fonts/local_fonts.module:102
error: modules/local_fonts/local_fonts.module: patch does not apply
Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
3042792-19.patch15.07 KB

Re-rolled patch please review!

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
FileSize
3042792-20.patch15.09 KB

Please review!

Status: Needs review » Needs work

The last submitted patch, 20: 3042792-20.patch, failed testing. View results

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
FileSize
3042792-22.patch17.17 KB

Fixed the tests which are failing

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.