Change flag_search_api.admin description from "Enable or disable Reindexing items on flagging action.
" into "Enable or disable reindexing items on flagging action."

CommentFileSizeAuthor
#4 flag_api_fixes-3045541.patch638 byteskavbiswa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ws.agency created an issue. See original summary.

kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented
Assigned: Unassigned » kavbiswa
kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented

Hi @ws.agency,

I need some more information on this issue.

As mentioned in the issue description for the module version (8.x-1.x-dev) to change the string from => to, i tried to search the mentioned string but couldn't found in version 8.x-1.x-dev of the module. [I think change is needed in issue description]

Then i downloaded the recommended version (8.x-1.4) and found the string is present in src/Form/FlagSearch/ApiConfigForm.php file line no:44.

So as per issue description, what i understand is that the required change is needed in 8.x-1.x-dev version in the file name mentioned above. ie. change string from Reindex item each time it is flagged/unflagged. to Enable or disable reindexing items on flagging action.

I will update the patch here. Let me know if my understanding is incorrect and then I will check accordingly.

Thanks.
Kaveri

kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented
Assigned: kavbiswa » Unassigned
Status: Active » Needs review
FileSize
flag_api_fixes-3045541.patch638 bytes

Please find the patch with the changes. Please review and let me know if any further changes is needed.

xSDx’s picture

xSDx CreditAttribution: xSDx at Websolutions Agency commented
Assigned: Unassigned » xSDx
Status: Needs review » Reviewed & tested by the community

Reviewed and works fine

  • xSDx committed 20b7c44 on 8.x-1.x authored by kavbiswa 
    Issue #3045541 by kavbiswa, xSDx: Change flag_search_api.admin...
xSDx’s picture

xSDx CreditAttribution: xSDx at Websolutions Agency commented
Status: Reviewed & tested by the community » Fixed
xSDx’s picture

xSDx CreditAttribution: xSDx at Websolutions Agency commented
Issue tags: +DrupalCon Amsterdam 2019
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
CreditAttribution: rachel_norfolk at Drupal Association commented
Issue tags: -DrupalCon Amsterdam 2019 +Amsterdam2019

retagging

xSDx’s picture

xSDx CreditAttribution: xSDx at Websolutions Agency commented
Status: Fixed » Closed (fixed)