Problem/Motivation

Per [#2827160], we shouldn't use @expectedException or @expectedExceptionMessage in tests any more.

Proposed resolution

We should use something like this instead:

$this->setExpectedException(MailHandlerException::class, 'Unable to determine message recipient');

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

WidgetsBurritos created an issue. See original summary.

kavbiswa’s picture

Assigned: Unassigned » kavbiswa
kavbiswa’s picture

Please review the updated patch.

kavbiswa’s picture

Assigned: kavbiswa » Unassigned
Status: Active » Needs review
WidgetsBurritos’s picture

Status: Needs review » Needs work

@kavbiswa,

The patch doesn't seem to be applying. Please check your patch and try again. Thank you.

kavbiswa’s picture

Status: Needs work » Needs review
FileSize
10.15 KB
kavbiswa’s picture

Please review the updated patch.

Status: Needs review » Needs work

The last submitted patch, 6: 3046172-6.patch, failed testing. View results

maliknaik’s picture

maliknaik’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: expected-exception-3046172.patch, failed testing. View results

kavbiswa’s picture

kavbiswa’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 3046172-12.patch, failed testing. View results

kavbiswa’s picture

Status: Needs work » Needs review
WidgetsBurritos’s picture

Status: Needs review » Needs work

Tests are failing so this still needs work

aleevas’s picture

Status: Needs review » Needs work

The last submitted patch, 17: 3046172-17.patch, failed testing. View results

aleevas’s picture

The next one

aleevas’s picture

Status: Needs work » Needs review
WidgetsBurritos’s picture

Status: Needs review » Reviewed & tested by the community

+1 RTBC

WidgetsBurritos’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.