Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Per [#2827160], we shouldn't use @expectedException or @expectedExceptionMessage in tests any more.
Proposed resolution
We should use something like this instead:
$this->setExpectedException(MailHandlerException::class, 'Unable to determine message recipient');
Comment | File | Size | Author |
---|---|---|---|
#19 | 3046172-18.patch | 10.56 KB | aleevas |
| |||
#19 | interdiff-17-18.txt | 4.13 KB | aleevas |
#19 | 3046172-18.patch | 10.56 KB | aleevas |
|
Comments
Comment #2
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #3
kavbiswa CreditAttribution: kavbiswa at Infosys commentedPlease review the updated patch.
Comment #4
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #5
WidgetsBurritos CreditAttribution: WidgetsBurritos as a volunteer commented@kavbiswa,
The patch doesn't seem to be applying. Please check your patch and try again. Thank you.
Comment #6
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #7
kavbiswa CreditAttribution: kavbiswa at Infosys commentedPlease review the updated patch.
Comment #9
maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commentedComment #10
maliknaik CreditAttribution: maliknaik as a volunteer and at Google Summer of Code commentedComment #12
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #13
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #15
kavbiswa CreditAttribution: kavbiswa at Infosys commentedComment #16
WidgetsBurritos CreditAttribution: WidgetsBurritos as a volunteer commentedTests are failing so this still needs work
Comment #17
aleevasHere is my patch
Comment #19
aleevasThe next one
Comment #20
aleevasComment #21
WidgetsBurritos CreditAttribution: WidgetsBurritos as a volunteer commented+1 RTBC
Comment #23
WidgetsBurritos CreditAttribution: WidgetsBurritos as a volunteer commented