Hi,

I thought the "Load previous" button for threads was not working but I just noticed that it is working but the listener is added very late. You have to wait that the ajax reload the inbox block in order to have your listener on the button.
We definitely want to have the listener just after loading the page.

The loading button should also only be there if we have more threads to load but I added this point in this issue: "Load Previous" appears in wrong situations

CommentFileSizeAuthor
#2 private_message-threads_load_late_listener-3046653-2.patch1 KBphjou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phjou created an issue. See original summary.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented
FileSize
private_message-threads_load_late_listener-3046653-2.patch1 KB

Just did a small patch in order to fix that, you should be able to load the previous conversations directly without waiting for the first refresh (default is 15 seconds).

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented
Status: Active » Needs review
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented
Title: Thread LOad previous event listener is added really late » Thread Load previous event listener is added very late
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented
Issue tags: +Seattle2019
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
CreditAttribution: phjou commented
Related issues: +#3038271: Inbox not working properly

This issue has been included in Inbox not working properly.

Waiting to be resolved there.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs review » Fixed

Fixed with https://www.drupal.org/project/private_message/issues/3038271

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.