Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Action
- Install/update drush to latest stable version 9
- Install module using composer
- Enable module using drush
- Execute command
drush inspect_config --only-error
Observed result
Command returns error message :
Command "inspect_config" is not defined.
Command for Drush 8 was brought by https://www.drupal.org/project/config_inspector/issues/2913793
Expected result
- Now we should handle Drush 9 support
- Validating schema of config files from Drush command is very useful for CI integration
Todo
- Port patch Drush 8 patch from https://www.drupal.org/project/config_inspector/issues/2913793 to Drush 9, if possible
- Work on fresh implementation, if not
Comment | File | Size | Author |
---|---|---|---|
#25 | 3047418-26-drush-10.patch | 1.05 KB | andypost |
Comments
Comment #2
andypostBasic implementation, provides
config:inspect
withinspect_config
alias commandNeeds to decide
- should it provide non-zero exit-code when there's troubles
- decide on command name - I like "config:inspect" but old command using outdated underscore "inspect_config"
Comment #3
davidferlay CreditAttribution: davidferlay at Skilld commented@andypost
Comment #4
davidferlay CreditAttribution: davidferlay at Skilld commentedI tested your patch @Andypost (#2) and it seems to work just great !
I think it would be great though to make it fully silent when no error, to avoid verbose in CI logs.
What do you think ?
Comment #5
andypostFix codestyle & add exit code
As I see it's common for drush commands to return empty header always (for ex.
drush watchdog:show
) so did not changeComment #6
andypostOne more example of usage
Comment #7
andypostlast bit of clean-up
Comment #8
davidferlay CreditAttribution: davidferlay at Skilld commented@andypost, you are right, empty header is common accross drush commands
Fortunately
--format=string
option is useful to only print result without headerFor readers, it's possible to print only errors list without any header using
drush config:inspect --only-error --format=string
Btw, I tested last patch from #7 and it seems working all fine !
Comment #9
davidferlay CreditAttribution: davidferlay at Skilld commentedComment #10
piggito CreditAttribution: piggito as a volunteer and at Skilld commenteda port of patch at #7 for drush 9.5 compatibility
Comment #11
piggito CreditAttribution: piggito as a volunteer and at Skilld commentedComment #12
vuilComment #14
vuilComment #16
vuilComment #17
vuilI revert the issue to Needs work as @andypost comment here.
Comment #18
vuilUpload a patch which is dependent to that issue.
Comment #20
vuilThe issue still Needs work.
Comment #21
vuilComment #22
vuilComment #23
Gábor HojtsyWhat needs work here? The Drush 9 commands are added. I don't understand why was the drush.inc added? That is certainly not for Drush 9.
Comment #24
andypostIt just needs to add drush 10 support
PS: added sniffers run, looks it needs follow-up to remove simpletest from drupalci.yml and polish remains
Comment #25
andypostIt just needs to remove few lines as there only 2 functional tests
Comment #26
andypostas 10 is current version also it needs to remove `core: 8.x` from info file
Comment #27
Gábor HojtsyWhy does this module need a drupalci.yml file in the first place? What do we need to customize?
Comment #28
vuilComment #30
vuilComment #31
andypost@Gabor it just optimize defaults