Make User Restrictions ready for Drupal 9 [#3050084]

 22/22 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------
  Line   src/Form/UserRestrictionsAddForm.php
 ------ ---------------------------------------------------
  17     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------------------------------------------
  Line   src/Plugin/UserRestrictionType/ClientIp.php
 ------ ---------------------------------------------------------------------------------------
  50     Call to deprecated method link() of class Drupal\Core\Config\Entity\ConfigEntityBase.
 ------ ---------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------
  Line   src/Plugin/UserRestrictionType/Email.php
 ------ ---------------------------------------------------------------------------------------
  33     Call to deprecated method link() of class Drupal\Core\Config\Entity\ConfigEntityBase.
 ------ ---------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------
  Line   src/Plugin/UserRestrictionType/Name.php
 ------ ---------------------------------------------------------------------------------------
  33     Call to deprecated method link() of class Drupal\Core\Config\Entity\ConfigEntityBase.
 ------ ---------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------
  Line   tests/src/Functional/UserRestrictionsLoginTest.php
 ------ ----------------------------------------------------------------------------------
  25     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  25     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  53     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  53     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
  95     Call to deprecated method format() of class Drupal\Component\Utility\SafeMarkup.
  95     Call to method format() of deprecated class Drupal\Component\Utility\SafeMarkup.
 ------ ----------------------------------------------------------------------------------

Comment	File	Size	Author
#6	3050084-5-d9-readiness.patch	5.29 KB	adammalone
#6	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.7 10 pass PHP 7.1 & MySQL 5.5, D8.7 10 pass
#4	3050084-4-d9-readiness.patch	5.16 KB	adammalone
#4	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.7 4 pass, 2 fail
#3	3050084-3-d9-readiness.patch	5.14 KB	adammalone
#3	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7 4 pass, 2 fail
#2	3050084-2-d9-readiness.patch	5.18 KB	adammalone
#2	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6.15 4 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 April 2019 at 03:02

adammalone created an issue. See original summary.

Comment #3

adammalone

English

Sydney

CreditAttribution: adammalone at Deloitte Digital commented 23 April 2019 at 03:38

Status:

Active

» Needs review

File	Size
3050084-3-d9-readiness.patch	5.14 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7 4 pass, 2 fail

1 file was hidden/shown/deleted

File	Size
3050084-2-d9-readiness.patch	5.18 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6.15 4 pass, 2 fail

Changes syntax of FormattableMarkup call.

Comment #5

23 April 2019 at 04:08

Status:

Needs review

» Needs work

The last submitted patch, 4: 3050084-4-d9-readiness.patch, failed testing. View results

Comment #6

adammalone

English

Sydney

CreditAttribution: adammalone at Deloitte Digital commented 23 April 2019 at 04:24

Status:

Needs work

» Needs review

File	Size
3050084-5-d9-readiness.patch	5.29 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.7 10 pass PHP 7.1 & MySQL 5.5, D8.7 10 pass

1 file was hidden/shown/deleted

File	Size
3050084-4-d9-readiness.patch	5.16 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.7 4 pass, 2 fail

Comment #7

23 April 2019 at 04:27

Status:

Needs review

» Needs work

The last submitted patch, 6: 3050084-5-d9-readiness.patch, failed testing. View results

Comment #8

23 April 2019 at 04:44

adammalone committed 7b62832 on 8.x-1.x

Issue #3050084 by adammalone: Make module ready for Drupal 9.

Comment #9

adammalone

English

Sydney

CreditAttribution: adammalone at Deloitte Digital commented 23 April 2019 at 05:29

Status:

Needs work

» Fixed

Comment #10

7 May 2019 at 05:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #11

Kristen Pol

she/her

English

Santa Cruz, CA, USA

CreditAttribution: Kristen Pol at Hook 42 commented 28 November 2019 at 05:32

Issue tags:

+Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.