In Social Blue theme settings
/admin/appearance/settings/socialblue
> Preview >
Show Background Image switcher is not saving when switched on.

CommentFileSizeAuthor
#2 Screen Shot 2019-05-01 at 11.48.33 am.png168.71 KBthe_glitch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

the_glitch created an issue. See original summary.

the_glitch’s picture

the_glitch CreditAttribution: the_glitch commented
Title: Show Background Image switch settings not saving (Node title field) » Show Background Image switch settings not saving
FileSize
Screen Shot 2019-05-01 at 11.48.33 am.png168.71 KB
the_glitch’s picture

the_glitch CreditAttribution: the_glitch commented

Can somebody paste the relevant fixed code here so I can put it in my subtheme?

Agamich’s picture

Agamich CreditAttribution: Agamich as a volunteer and at Lemberg Solutions, Open Social, Drupal Ukraine Community for Open Social commented
Status: Active » Needs review

I added this suggestion in this PR: https://github.com/goalgorilla/open_social/pull/1356

Kingdutch’s picture

Kingdutch
he/him
Primary language English
CreditAttribution: Kingdutch at Open Social commented
Status: Needs review » Needs work

Pull request updated with some requested changes.

ronaldtebrake’s picture

ronaldtebrake CreditAttribution: ronaldtebrake as a volunteer and for Open Social commented
Status: Needs work » Reviewed & tested by the community
jaapjan’s picture

jaapjan CreditAttribution: jaapjan as a volunteer and at Open Social commented
Status: Reviewed & tested by the community » Fixed

  • Agami4 committed 0272771 on 8.x-7.x 
    Issue #3051857 by agami4: Remove console.log
  • Agami4 committed 52c223e on 8.x-7.x
    Issue #3051857 by agami4: Clear preview.js file
  • 67a698b committed on 8.x-7.x
    Issue #3051857 by agami4: show background image after saving on settings...
  • Agami4 committed da7f6c7 on 8.x-7.x
    Issue #3051857 by agami4: Update javascript for preview banner image
  • ronaldtebrake authored 40a300b on 8.x-7.x
    Merge pull request #1356 from goalgorilla/feature/3051857-settings-...
  • 445af77 committed on 8.x-7.x
    Issue #3051857 by agami4: Update setting on the preview.js

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.