While evaluating this module I noticed in the info.yml that the dependency namespacing for the views_add_button is incorrect.
All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml
It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).
It is useful for DrupalCi to download the right dependencies and Installation profiles to work well.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
I am showing a new contributor the patching process and thought this would be a perfect first patch and review for them
Comment | File | Size | Author |
---|---|---|---|
#2 | views_add_button-infofile-3051999-2.patch | 337 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickI have uploaded a patch that fixes the namespacing issue in the info.yml file
drupal:views_add_button
should read
views_add_button:views_add_button
Thanks for working on this project. I am having a new contributor test and review the patch now.
Comment #3
fayedm CreditAttribution: fayedm at Kanopi Studios commentedCode review looks, good matches documentation for namespacing.
Patch applied locally. Marking RTBC.
Comment #5
laboratory.mikeOK, patched and uploaded for release in 8.x-1.1. Thanks.