Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently there are still some \Drupal calls in classes. Which should be replaced by injecting those services.
------ ------------------------------------------------------------------------------
Line src/EventSubscriber/ProxySubscriber.php
------ ------------------------------------------------------------------------------
64 \Drupal calls should be avoided in classes, use dependency injection instead
129 \Drupal calls should be avoided in classes, use dependency injection instead
132 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------
Line src/FetchManager.php
------ ------------------------------------------------------------------------------
50 \Drupal calls should be avoided in classes, use dependency injection instead
61 \Drupal calls should be avoided in classes, use dependency injection instead
71 \Drupal calls should be avoided in classes, use dependency injection instead
81 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------
Line src/Form/SettingsForm.php
------ ------------------------------------------------------------------------------
55 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-3054293-9-12.txt | 533 bytes | Waldoswndrwrld |
#12 | 3054293-12.patch | 9.57 KB | Waldoswndrwrld |
#10 | interdiff-3054293-8-9.txt | 751 bytes | Waldoswndrwrld |
#10 | 3054293-9.patch | 9.61 KB | Waldoswndrwrld |
#8 | interdiff-3054293-4-8.txt | 4.09 KB | Waldoswndrwrld |
Comments
Comment #2
Waldoswndrwrld CreditAttribution: Waldoswndrwrld at iO commentedNeeded services have been injected.
Comment #4
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedPatch failed testing.
Needs work
Comment #5
Waldoswndrwrld CreditAttribution: Waldoswndrwrld at iO commentedFixed coding standards.
Comment #7
JeroenT$requestStack should be $request_stack.
Those changes are not necessary. Please remove.
the arguments are separated by a", ". The space is currently missing.
Those changes are not necessary. Please remove.
Comment #8
Waldoswndrwrld CreditAttribution: Waldoswndrwrld at iO commentedChanges have been made and unnecessary changes have been reverted.
Comment #10
Waldoswndrwrld CreditAttribution: Waldoswndrwrld at iO commentedFixed missing configFactory variable.
Comment #11
JeroenT->get('stage_file_proxy.settings') is no longer necessary. This can be changed to $config->get('verify').
Comment #12
Waldoswndrwrld CreditAttribution: Waldoswndrwrld at iO commentedImplemented #11
Comment #14
JeroenTComment #15
JeroenTDid some manual testing. Module is still working and all \Drupal calls are replaced by DI. Marking as RTBC.
Comment #16
BarisW CreditAttribution: BarisW at LimoenGroen commentedThanks for the patch and the review. I needed to re-roll the patch after #2992856: Handle *all* guzzle exceptions gracefully landed, but that was easy.
Comment #18
BarisW CreditAttribution: BarisW at LimoenGroen commented