Problem/Motivation

The currently existing functionality implements "Did you mean". The views plugin to select for it is named "Spellcheck".

Proposed resolution

I suggest to consistently rename the existing functionality to "Did you mean" throughout the project files.

Remaining tasks

  • After that we should a second Views plugin that offers a "Spellcheck" in way that offers multiple suggestions to user instead a single "Did you mean" suggestion.
  • Update the documentation and add this link to this project's homepage on d.o.
CommentFileSizeAuthor
#8 interdiff-5-8.txt1.22 KBtim-diels
#8 3054367-8.patch12.16 KBtim-diels
#5 3054367-5.patch12.16 KBtim-diels
#5 interdiff-3-5.txt1.78 KBtim-diels
#3 3054367-3.patch12.04 KBtim-diels
#3 Schermafbeelding 2019-05-29 om 16.36.13.png79.74 KBtim-diels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Title: distinguish "Did you mean" and "Spellcheck" » distinguish between "Did you mean" and "Spellcheck"
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Calibrate commented
Status: Active » Needs review
FileSize
Schermafbeelding 2019-05-29 om 16.36.13.png79.74 KB
3054367-3.patch12.04 KB

Found some time to work on this issue and with some suggestions of @mkalkbrenner I came up with the patch attached.

suggestions

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Needs work

I only found some nitpicks but haven't tested this manually at all.

  1. +++ b/README.txt
@@ -3,9 +3,14 @@ README.txt
-Edit your Views search page and add the Spellcheck field to the Views' Header and/or Footer.
+Edit your Views search page and add the Did You Mean or Suggestions Spellcheck field to the Views' Header and/or Footer.

    I think the 80 cols rule also goes for readme files. So we should probably rewrap this under 80 cols wide. 

  2. +++ b/src/Plugin/views/area/SuggestionsSpellCheck.php
@@ -0,0 +1,254 @@
+  private $currentQuery;

    This should be protected instead of private, so that others extending this class can easily change this. 

  3. +++ b/src/Plugin/views/area/SuggestionsSpellCheck.php
@@ -0,0 +1,254 @@
+    // Basically, work you way from the rightmost digit of the "odometer"...

    /s/you/your/

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Calibrate commented
Status: Needs work » Needs review
FileSize
interdiff-3-5.txt1.78 KB
3054367-5.patch12.16 KB

Solved the remarks.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented

This looks good, I have not manually tested this and am not confident enough about the codebase to rtbc without testing, but the patch gets a +1.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Issue summary: View changes

How to use
----------

Edit your Views search page and add the Did You Mean or Suggestions Spellcheck field to the Views' Header and/or Footer.

@tim-diels, would you care to add this to the documentation once this gets in?


The patch looks good, thanks! Feel free to fix or ignore this tiny nitpick:

+++ b/src/Plugin/views/area/SuggestionsSpellCheck.php
@@ -0,0 +1,254 @@
+    if ($this->options['search_api_spellcheck_hide_on_result'] == FALSE || ($this->options['search_api_spellcheck_hide_on_result'] && $empty)) {

+++ b/src/Plugin/views/area/SuggestionsSpellCheck.php
@@ -0,0 +1,254 @@
+      if ($i == 0) {

== => ===

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: tim-diels at Calibrate commented
FileSize
3054367-8.patch12.16 KB
interdiff-5-8.txt1.22 KB

@mpp I'm sure willing to add that to the documentation once it gets committed.

I changed the 2 == to ===

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Reviewed & tested by the community

RTBC based on the feedback by @mpp and my own review earlier.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Issue summary: View changes

Great!

dksdev01’s picture

dksdev01 CreditAttribution: dksdev01 commented

Any update on 8.x release branch?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.