After upgrading to 8.x-1.12, I receive an error when navigating to /admin/config/quick-node-clone. It looks like the form isn't checking to make sure the value gets set before using it.

To replicate: Make sure none of the entity types are selected on the exclusion list of the form.

Warning: array_keys() expects parameter 1 to be array, null given in Drupal\quick_node_clone\Form\QuickNodeCloneEntitySettingsForm->buildForm() (line 123 of [docroot]\modules\quick_node_clone\src\Form\QuickNodeCloneEntitySettingsForm.php) 
#0 [docroot]\core\includes\bootstrap.inc(587): _drupal_error_handler_real(2, 'array_keys() ex...', '[docroot]', 123, Array) 
#1 [internal function]: _drupal_error_handler(2, 'array_keys() ex...', '[docroot]', 123, Array) 
#2 [docroot]\modules\quick_node_clone\src\Form\QuickNodeCloneEntitySettingsForm.php(123): array_keys(NULL) 
#3 [docroot]\modules\quick_node_clone\src\Form\QuickNodeCloneNodeSettingsForm.php(45): Drupal\quick_node_clone\Form\QuickNodeCloneEntitySettingsForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) 
#4 [internal function]: Drupal\quick_node_clone\Form\QuickNodeCloneNodeSettingsForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) 
#5 [docroot]\core\lib\Drupal\Core\Form\FormBuilder.php(519): call_user_func_array(Array, Array) 
#6 [docroot]\core\lib\Drupal\Core\Form\FormBuilder.php(276): Drupal\Core\Form\FormBuilder->retrieveForm('quick_node_clon...', Object(Drupal\Core\Form\FormState)) 
#7 [docroot]\core\lib\Drupal\Core\Controller\FormController.php(93): Drupal\Core\Form\FormBuilder->buildForm('quick_node_clon...', Object(Drupal\Core\Form\FormState)) 
#8 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) 
#9 [docroot]\core\lib\Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) 
#10 [docroot]\core\lib\Drupal\Core\Render\Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() 
#11 [docroot]\core\lib\Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) 
#12 [docroot]\core\lib\Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) 
#13 [docroot]\vendor\symfony\http-kernel\HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() 
#14 [docroot]\vendor\symfony\http-kernel\HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) 
#15 [docroot]\core\lib\Drupal\Core\StackMiddleware\Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#16 [docroot]\core\lib\Drupal\Core\StackMiddleware\KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#17 [docroot]\core\modules\page_cache\src\StackMiddleware\PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#18 [docroot]\core\modules\page_cache\src\StackMiddleware\PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#19 [docroot]\core\lib\Drupal\Core\StackMiddleware\ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#20 [docroot]\core\lib\Drupal\Core\StackMiddleware\NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#21 [docroot]\vendor\stack\builder\src\Stack\StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#22 [docroot]\core\lib\Drupal\Core\DrupalKernel.php(693): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#23 [docroot]\index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) 
#24 {main}.
CommentFileSizeAuthor
#5 3054712-5.patch861 bytesSurfinSpirit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tclark62 created an issue. See original summary.

tclark62’s picture

Issue summary: View changes
tclark62’s picture

Issue summary: View changes
Anybody’s picture

Version: 8.x-1.12 » 8.x-1.x-dev

Please recheck with the latest dev version. Issues are always against dev!

SurfinSpirit’s picture

FileSize
861 bytes

Can be reproduced on latest dev, attaching a patch.

SurfinSpirit’s picture

Status: Active » Needs review
Ankush_03’s picture

Status: Needs review » Reviewed & tested by the community

Patch #5 Working fine for me.

Neslee Canil Pinto’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.