While evaluating this project we noticed a coding standard that could be cleaned up in the info.yml file.

All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml filehttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

Thanks, patch to follow!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
FileSize
387 bytes

Here's a patch that resolves the coding standards, thanks!

alonaoneill’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on the module!

acbramley’s picture

Status: Reviewed & tested by the community » Fixed
volkswagenchick’s picture

thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.