drupal-check -ad web/modules/contrib/eu_cookie_compliance
13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------------
Line eu_cookie_compliance.module
------ --------------------------------------------------------
190 Variable $primary_button_label might not be defined.
192 Variable $secondary_button_label might not be defined.
193 Variable $primary_button_class might not be defined.
194 Variable $secondary_button_class might not be defined.
200 Variable $primary_button_label might not be defined.
202 Variable $secondary_button_label might not be defined.
203 Variable $primary_button_class might not be defined.
204 Variable $secondary_button_class might not be defined.
258 Variable $click_confirmation might not be defined.
259 Variable $scroll_confirmation might not be defined.
463 Call to static method query() on an unknown class
Drupal\smart_ip\SmartIp.
------ --------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Controller/CheckIfEuCountryJsController.php
------ ----------------------------------------------------------------------
20 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Controller/StoreConsent.php
------ ----------------------------------------------------------------------
18 \Drupal calls should be avoided in classes, use dependency injection
instead
20 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Form/EuCookieComplianceConfigForm.php
------ ----------------------------------------------------------------------
126 \Drupal calls should be avoided in classes, use dependency injection
instead
835 Call to deprecated function drupal_set_message().
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Plugin/ConsentStorage/BasicConsentStorage.php
------ ----------------------------------------------------------------------
24 \Drupal calls should be avoided in classes, use dependency injection
instead
25 \Drupal calls should be avoided in classes, use dependency injection
instead
27 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Plugin/ConsentStorageBase.php
------ ----------------------------------------------------------------------
94 \Drupal calls should be avoided in classes, use dependency injection
instead
94 \Drupal calls should be avoided in classes, use dependency injection
instead
98 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

------ -----------------------------------------------------------------------
Line src/Plugin/ConsentStorageManager.php
------ -----------------------------------------------------------------------
30 Plugin manager has cache backend specified but does not declare cache
tags.
------ -----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Routing/CheckIfEuCountryJs.php
------ ----------------------------------------------------------------------
17 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

Drupal 9 compatibility issues I will try to submit a patch if someone doesn't beat me to it :)

Comments

ikit-claw created an issue. See original summary.

svenryen’s picture

Great, looking forward to your patch!

ikit-claw’s picture

Assigned: Unassigned » ikit-claw
idebr’s picture

Note that only 835 Call to deprecated function drupal_set_message(). has to be changed for Drupal 9 compatibility. The other lines are suggestions by the DrupalPractice code sniffer.

ikit-claw’s picture

Status: Active » Closed (duplicate)

@idebr looks like someone has gone ahead and fixed that issue on the dev branch already. Ha well will close the ticket then. If you want the sniffer issues patching let me know.

mbovan’s picture

Status: Closed (duplicate) » Fixed

Since the module is Drupal 9 compatible, I think the status of this issue should have been fixed.

mbovan’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture