Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently this module has a dependency on jQuery. However, jQuery is no longer required for Drupal, and it seems a waste to have to load a big library in order to load the instagram script from a remote url.
Proposed resolution
Add the external script as a library dependency, so it gets loaded when the library is attached.
Remaining tasks
Do it.
User interface changes
None
API changes
None.
Data model changes
None.
Release notes snippet
None.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3057264-5.patch | 1.35 KB | kim.pepper |
| |||
#3 | media-entity-instagram-3057264-3.patch | 434 bytes | jigish.addweb |
Comments
Comment #2
kim.pepperLooks like it is already loaded in media_entity_instagram.libraries.yml but there is an issue with ckeditor
Comment #3
jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented@kim.pepper, please find the patch for the same, hope this will helps you.
Thanks
Comment #5
kim.pepperWe have to actually remove the usage of jQuery as well.
Here's something like what I think we need.
Comment #7
jibranHEAD is failing see #3083313: Fix the failing HEAD
Comment #8
jibranWe have a green patch so setting it to RTBC.
Comment #10
chr.fritschI like. Thank you for getting rid of that.