Problem/Motivation
This is a subset of the descriptions originally included in #2570985: Update the module descriptions on the Extend page to make the review easier.
The description of a module on the Extend page, describes what the module does.
Not all module descriptions on the Extend page follow the common format, as described in the Help text standard.
Module descriptions were reviewed and changed for Drupal 8, The module description on the Extend page, should follow the wording on the module's help page because these have been reviewed previously.
Proposed resolution
Change the descriptions in the modules .info.yml files for the stable modules so that they are correct, consistent, follow the same format, and fit with the wording used in the module's Help text.
Several modules were added to core in since this issue was started. If a module description is not in this patch consider opening a new issue and avoid scope creep.
Remaining tasks
Review the patch and make sure that all the changed help pages are correct, consistent, follow the same format, and fit with the wording used in the module's Help text, at /admin/help/module-name
User interface changes
This is a UI text change.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#93 | interdiff-88-93.txt | 2.74 KB | nod_ |
#93 | core-3060616-93.patch | 18.56 KB | nod_ |
| |||
#88 | interdiff-81-88.txt | 363 bytes | nod_ |
#88 | core-3060616-88-1.patch | 16.6 KB | nod_ |
| |||
#87 | 3060616-87.patch | 18.65 KB | elber |
|
Issue fork drupal-3060616
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
ifrikI'm working on this during DevDays.
Comment #3
ifrikModules that should be covered in this issue: Blocks, CKEditor, Date time, Text editor, Field, Filter, Forum, Help, History, Link, Interface translation, Menu UI, Migrate Drupal, Node, Option, Path, Quick Edit, RDF, Responsive Image, Restful Webservices, Serialization, Shortcut, Testing, Statistics, Syslog, System, Text, Toolbar, Activity tracker, Update Manager, User, Views
Comment #4
ifrikThis patch changes the module descriptions for the modules listed above, to ensure that they fit the formal criteria of forming a proper sentence together with the module name, and to use the wording of the module help texts which have been reviewed previously.
To review this, the module description can be compared to the beginning of the Help page for each module.
The module description of the Node module is used in a test, therefore this is also changed.
Comment #6
alexpottAlmost certainly this patch needs a reroll for D9.
Comment #7
swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commentedComment #8
swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commentedHii @alexpott, i have rerolled patch for 9.0.x-dev, Kindly review.
Comment #9
xjmThese string changes would be a minor-only. Since 8.9.x and 9.0.x are now in beta, I'm moving this to 9.1.x. Thanks!
Comment #10
xjmThere's some syntax error in #8; maybe a quoting delimiter problem somewhere.
Comment #11
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedHere I have again reroll patch #4.
Comment #13
mmatsoo CreditAttribution: mmatsoo at Chromatic commentedRe-rolled patch from #11 against 9.2.x.
Comment #14
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedI can confirm that the latest patch applies cleanly on the
9.2.x
branch.I'm not 100% sure how to confirm this is RTBC. Do we need to compare the help text page and the info file text again?
Comment #15
mmatsoo CreditAttribution: mmatsoo at Chromatic commented@adamzimmermann When I initially re-rolled the patch, I reviewed each description text and found it was of good quality. (Messaging, grammar, spelling.)
Truly, I did not compare those texts to the modules' help text. Looking now, I see that the module help text is often much longer. Some examples for CKEditor and Datetime:
CKEditor Help Text
"The CKEditor module provides a highly-accessible, highly-usable visual text editor and adds a toolbar to text fields. Users can use buttons to format content and to create semantically correct and valid HTML. The CKEditor module uses the framework provided by the Text Editor module. It requires JavaScript to be enabled in the browser."
vs
ckeditor.info.yml description in patch
"Provides a visual text editor (WYSIWYG) and adds a toolbar to text fields using CKEditor."
Datetime Help Text
"The Datetime module provides a Date field that stores dates and times. It also provides the Form API elements datetime and datelist for use in programming modules. See the Field module help and the Field UI module help pages for general information on fields and how to create and manage them."
vs
datetime.info.yml description in patch
"Defines field types for storing dates and times."
I personally like having these succinct descriptions in the info.yml files. I could be swayed, but I do not really see any benefit in copying the help text, word for word. Not sure who makes the final decision.
Comment #16
mmatsoo CreditAttribution: mmatsoo at Chromatic commentedComment #17
catchPatch doesn't apply, but also noticed some things:
This line duplicates itself - the visual text editor and the 'toolbar to text fields' are the same thing.
The forum module doesn't 'allow users to create threaded discussion forums' - it provides a discussion forum, within which users can create threaded discussions, so the original language is more accurate and precise.
Many of the other items are changing language from "Provides a [thing]" to "Allows [someone] to do [thing]".
fwiw I prefer the "Provides a [thing]" language since it's more direct, so I think it would be better to consistently move towards the shorter more direct language here.
Comment #18
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedRe-rolled the patch. If there is a consensus around the description syntax I'm happy to help with that.
FWIW the "allows" syntax is in one of the examples, however I'm personally always a fan of short direct descriptions.
https://www.drupal.org/node/632280#s-1-short-description
Comment #19
ifrikThe wording "Allows users... " was explicitely choosen when we rewrote the help texts and these short descriptions for those case where the modules makes it possible for users (including site builders) to set up something on the site, rather then providing something out of the box.
The forum module does not provide a forum - it provides the functionality for site builders to create one or several, which other users can then use. The difference is usually visible in a minimal site installation rather then a default.
Another example where the difference might be clearer is the Taxonomy module: It just provides the option for users to create vocabularies and terms, but it does not provide a specific vocabulary - even though the Default installation also adds a Tags vocabulary during the installation process.
Comment #20
nitesh624Assigining myself working on it will update in few hours
Comment #21
nitesh624Comment #22
nitesh624Comment #23
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedPatch can't be applied,shows error.
Comment #24
paulocsI didn't have problems to apply the patch. Moving to RTBC as it looks good to me.
Comment #25
catchI don't think this is how a new user would understand the forum module.
The forum module gives you an empty forum (at least in the general sense), because it provides an empty forum index at /forum. You can then add containers and forums within that. Drupal doesn't have a separate word for 'the collection of forums and containers' - it is either 'Forum', 'Forum index' or 'Forums'.
If someone installs phpbb (if that's still going...), then they are installing 'a forum' - even if they then need to create their forum structure within it.
Views + field UI + taxonomy module also provide the functionality for site builders to create one or several forums, but you have to configure things as opposed to just creating content.
This hunk is missing from the patch entirely now, and the patches failed (bot says build successful, but there are thousands of failures), so not sure what's going on with #22. An interdiff would be useful.
Comment #26
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedFixed #22 and change description.
Comment #27
sonam.chaturvedi CreditAttribution: sonam.chaturvedi at QED42 for Drupal India Association commentedComment #28
sonam.chaturvedi CreditAttribution: sonam.chaturvedi at QED42 for Drupal India Association commentedAs per #3, module description change should also be covered for "RESTful Web Services" module.
The description change for this module is missing in patch#26.
Current description: 'Exposes entities and other resources as RESTful web API'
Expected description (as per patch#4): 'Provides a framework for exposing REST resources.'
Moving to Needs Work
Comment #29
KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commentedComment #30
KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commentedAddressed #28
Comment #31
sonam.chaturvedi CreditAttribution: sonam.chaturvedi at QED42 for Drupal India Association commentedComment #32
sonam.chaturvedi CreditAttribution: sonam.chaturvedi at QED42 for Drupal India Association commentedVerified and tested patch#30. Patch applied successfully and looks good to me.
Testing Steps:
1. Apply patch#30
2. Goto Extend page
3. For below modules, check module description is correct, consistent with "Help text"
"Blocks, CKEditor, Date time, Text editor, Field, Filter, Forum, Help, History, Link, Interface translation, Menu UI, Migrate Drupal, Node, Option, Path, Quick Edit, RDF, Responsive Image, Restful Webservices, Serialization, Shortcut, Testing, Statistics, Syslog, System, Text, Toolbar, Activity tracker, Update Manager, User, Views"
Test Result: Module description of listed modules looks good.
Before Patch
After Patch
Moving to RBTC
Comment #33
catchI'm not sure about some of these changes.
For example in the removed sentence, WYSIWYG is right at the front, meaning you immediately see what it's about, the change puts it at the end.
Similarly allows user to configure is mostly redundant here - most modules allow users to configure something - and the information specific to the module is moved to the end of the sentence.
Comment #36
quietone CreditAttribution: quietone as a volunteer commentedVery nice to see progress on this issue.
Due to my experience with Bug Smash Initiative and looking at old issues I know there are duplicates of this. Let me see if I can find them. Yes, found them, they are:
Closing both as duplicates and adding credit for Pancho and dawehner.
#33. I too thought that some of the changes were odd. But the IS states that this issue is to "Change the descriptions in the modules .info.yml files for the stable modules so that they are correct, consistent, follow the same format, and fit with the wording used in the module's Help text." And that is what the change for CKEditor does. I have not read any of the 'standards' about help texts so I might be missing something important.
And a final note to all, remember to search for duplicates.
Comment #37
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedpatch #30 can't be applied.Needs reroll.
Comment #38
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedRerolled patch #30.please check
Comment #39
quietone CreditAttribution: quietone as a volunteer commentedAbhijith S, When a patch needs a reroll there is no need to show the output from the command, it just makes noise in the issue queue. It will save you time and help keep the focus on the issue. And to help reviewers add an interdiff, or a diff, whichever is appropriate. There are instructions for creating an interdiff.
Comment #40
paulocsI'll provide a patch.
Comment #41
paulocs1 - I didn't have any problem to apply patch #30.
2- I created a new patch that address comment #33 but I'm not sure if it is more clear.
ckeditor.info.yml
as IMHO it looks good as it is.Cheers, Paulo.
Comment #43
BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commentedHi @paulocs,
thanks for the patch.
Patch applies cleanly and works as expected.
Comment #44
quietone CreditAttribution: quietone as a volunteer commentedThere are two other issues that are modifying the description in info.yml files. Should the work from those be moved into this issue to ensure they also fit with the Help pages?
Comment #45
Neslee Canil PintoComment #46
Neslee Canil PintoMoved Content Moderation and File modules info.yml description changes here, as per #44
Comment #47
quietone CreditAttribution: quietone as a volunteer commented@Neslee Canil Pinto, thanks for the interest in this issue. Can you explain why you think it is within scope to add the changes from the other issues here?
I found another issue that tweaks the .info files, #1924996: Fix error and improve on module descriptor text for the Extend page. Again, should those changes move here or is it out of scope?
Comment #48
Neslee Canil Pinto@quietone I believe it would be good if we fix all the description-related things under info.yml to be fixed in a single go. what do you think?
Comment #49
quietone CreditAttribution: quietone as a volunteer commented@Neslee Canil Pinto, I am a bit unsure because of the second paragraph of the Remaining Tasks. And I have not been involved in this issue of the parent so I don't know the full history.
Comment #50
Rinku Jacob 13 CreditAttribution: Rinku Jacob 13 at Zyxware Technologies commentedi can't apply patch #46 for drupal 9.3.x-dev. getting error while applying this patch
Comment #52
quietone CreditAttribution: quietone as a volunteer commentedClosed #2999411: Update the Content Moderation module description and #3033185: Update the description in file.info.yml as duplicates. The changes there have already moved over here thanks to Neslee Canil Pinto.
@Rinku Jacob 13 - thank you for looking into this issue. Posting screenshots of your CLI does not advance the issue. So, I've removed the issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you.
Comment #53
quietone CreditAttribution: quietone as a volunteer commentedUpdated the IS
This needs a reroll.
Comment #56
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commentedApplied patch #30 applied successfully for ref sharing screenshot ..
Thanks for the patch
Comment #57
quietone CreditAttribution: quietone as a volunteer commented@vikashsoni thank you for looking into this issue. This issue is not ready for screenshots, the previous comment explained that this issue needed a reroll. Once that work is done, and the tests are passing it would be OK to use your time to make screenshots. But using an old patch to make screenshots does not advance the issue. Therefor, credit has been removed per How is credit granted for Drupal core issues.
Comment #58
catchComment #59
volkswagenchickTagging for Drupal Europe2021. Thanks
Comment #60
kostyashupenkoComment #61
eojthebraveThere is some overlap between this issue and #3223179: Remove references to 'administrators' in module descriptions where the text "administrator" is being removed from module descriptions. Both patches change the description for System and Menu UI. I think we should favor the changes already in this issue since they'll also resolve the issue for those two modules.
That leaves the descriptions for Ban (changed to: "Allows banning visits from specific IP addresses." instead of "Allows administrators to ban visits from specific IP addresses.") and Configuration Manager (changed to: "Allows importing and exporting configuration changes." instead of "Allows administrators to import and export configuration changes.") in the other issue.
It seems to me like we could update the descriptions for Ban and Configuration Manager in this issue and resolve both issue at the same time? Or should that remain a separate change? Either way, once this one is resolved we'll be able to know what to do with the other.
Comment #62
mradcliffeI removed issue credit for Isabella Rowntree as the issue fork contains only unrelated (spam) comments following How is credit granted for Drupal core issues. Thank you, @quietone for the link in the comment above.
Comment #64
elberComment #65
elberComment #66
hmendes CreditAttribution: hmendes at CI&T commentedHey @elber, your patch has a ton of other stuff non related to this issue. Please leave only the chances needed.
Comment #67
elberComment #68
elberComment #69
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedComment #70
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedVerified and tested by applying the patch, patch fails to apply.
Getting below error:
Checking patch core/modules/ban/ban.info.yml...
error: while searching for:
name: Ban
type: module
description: 'Allows administrators to ban visits from specific IP addresses.'
package: Core
version: VERSION
configure: ban.admin_page
error: patch failed: core/modules/ban/ban.info.yml:1
error: core/modules/ban/ban.info.yml: patch does not apply
Checking patch core/modules/block/block.info.yml...
error: while searching for:
name: Block
type: module
description: 'Controls the visual building blocks a page is constructed with. Blocks are boxes of content rendered into an area, or region, of a web page.'
package: Core
version: VERSION
configure: block.admin_display
error: patch failed: core/modules/block/block.info.yml:1
error: core/modules/block/block.info.yml: patch does not apply
Checking patch core/modules/config/config.info.yml...
error: while searching for:
name: 'Configuration Manager'
type: module
description: 'Allows administrators to import and export configuration changes.'
package: Core
version: VERSION
configure: config.sync
error: patch failed: core/modules/config/config.info.yml:1
error: core/modules/config/config.info.yml: patch does not apply
Checking patch core/modules/content_moderation/content_moderation.info.yml...
error: while searching for:
name: 'Content Moderation'
type: module
description: 'Provides moderation states for content.'
version: VERSION
package: Core
configure: entity.workflow.collection
error: patch failed: core/modules/content_moderation/content_moderation.info.yml:1
error: core/modules/content_moderation/content_moderation.info.yml: patch does not apply
Checking patch core/modules/datetime/datetime.info.yml...
error: while searching for:
name: Datetime
type: module
description: Defines datetime form elements and a datetime field type.
package: Field types
version: VERSION
dependencies:
error: patch failed: core/modules/datetime/datetime.info.yml:1
error: core/modules/datetime/datetime.info.yml: patch does not apply
Checking patch core/modules/editor/editor.info.yml...
error: while searching for:
name: 'Text Editor'
type: module
description: 'Provides a means to associate text formats with text editor libraries such as WYSIWYGs or toolbars.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/editor/editor.info.yml:1
error: core/modules/editor/editor.info.yml: patch does not apply
Checking patch core/modules/field/field.info.yml...
error: while searching for:
name: Field
type: module
description: 'Field API to add fields to entities like nodes and users.'
package: Core
version: VERSION
error: patch failed: core/modules/field/field.info.yml:1
error: core/modules/field/field.info.yml: patch does not apply
Checking patch core/modules/file/file.info.yml...
error: while searching for:
name: File
type: module
description: 'Defines a field type for files.'
package: Field types
version: VERSION
dependencies:
error: patch failed: core/modules/file/file.info.yml:1
error: core/modules/file/file.info.yml: patch does not apply
Checking patch core/modules/filter/filter.info.yml...
error: while searching for:
name: Filter
type: module
description: 'Filters content in preparation for display.'
package: Core
version: VERSION
configure: filter.admin_overview
error: patch failed: core/modules/filter/filter.info.yml:1
error: core/modules/filter/filter.info.yml: patch does not apply
Checking patch core/modules/help/help.info.yml...
error: while searching for:
name: Help
type: module
description: 'Manages the display of online help.'
package: Core
version: VERSION
error: patch failed: core/modules/help/help.info.yml:1
error: core/modules/help/help.info.yml: patch does not apply
Checking patch core/modules/history/history.info.yml...
error: while searching for:
name: History
type: module
description: 'Records which user has read which content.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/history/history.info.yml:1
error: core/modules/history/history.info.yml: patch does not apply
Checking patch core/modules/link/link.info.yml...
error: while searching for:
name: Link
type: module
description: 'Provides a simple link field type.'
package: Field types
version: VERSION
dependencies:
error: patch failed: core/modules/link/link.info.yml:1
error: core/modules/link/link.info.yml: patch does not apply
Checking patch core/modules/locale/locale.info.yml...
error: while searching for:
name: 'Interface Translation'
type: module
description: 'Translates the built-in user interface.'
configure: locale.translate_page
package: Multilingual
version: VERSION
error: patch failed: core/modules/locale/locale.info.yml:1
error: core/modules/locale/locale.info.yml: patch does not apply
Checking patch core/modules/menu_ui/menu_ui.info.yml...
error: while searching for:
name: Menu UI
type: module
description: 'Allows administrators to customize the site navigation menu.'
package: Core
version: VERSION
configure: entity.menu.collection
error: patch failed: core/modules/menu_ui/menu_ui.info.yml:1
error: core/modules/menu_ui/menu_ui.info.yml: patch does not apply
Checking patch core/modules/migrate_drupal/migrate_drupal.info.yml...
error: while searching for:
name: Migrate Drupal
type: module
description: 'Contains migrations from older Drupal versions.'
package: Migration
version: VERSION
dependencies:
error: patch failed: core/modules/migrate_drupal/migrate_drupal.info.yml:1
error: core/modules/migrate_drupal/migrate_drupal.info.yml: patch does not apply
Checking patch core/modules/node/node.info.yml...
error: while searching for:
name: Node
type: module
description: 'Allows content to be submitted to the site and displayed on pages.'
package: Core
version: VERSION
configure: entity.node_type.collection
error: patch failed: core/modules/node/node.info.yml:1
error: core/modules/node/node.info.yml: patch does not apply
Checking patch core/modules/options/options.info.yml...
error: while searching for:
name: Options
type: module
description: 'Defines selection, check box and radio button widgets for text and numeric fields.'
package: Field types
version: VERSION
dependencies:
error: patch failed: core/modules/options/options.info.yml:1
error: core/modules/options/options.info.yml: patch does not apply
Checking patch core/modules/path/path.info.yml...
error: while searching for:
name: Path
type: module
description: 'Allows users to rename URLs.'
package: Core
version: VERSION
configure: entity.path_alias.collection
error: patch failed: core/modules/path/path.info.yml:1
error: core/modules/path/path.info.yml: patch does not apply
Checking patch core/modules/quickedit/quickedit.info.yml...
error: while searching for:
name: Quick Edit
type: module
description: 'In-place content editing.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/quickedit/quickedit.info.yml:1
error: core/modules/quickedit/quickedit.info.yml: patch does not apply
Checking patch core/modules/rdf/rdf.info.yml...
error: while searching for:
name: RDF
type: module
description: 'Enriches your content with metadata to let other applications (e.g. search engines, aggregators) better understand its relationships and attributes.'
package: Core
version: VERSION
error: patch failed: core/modules/rdf/rdf.info.yml:1
error: core/modules/rdf/rdf.info.yml: patch does not apply
Checking patch core/modules/responsive_image/responsive_image.info.yml...
error: while searching for:
name: Responsive Image
type: module
description: 'Provides an image formatter and breakpoint mappings to output responsive images using the HTML5 picture tag.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/responsive_image/responsive_image.info.yml:1
error: core/modules/responsive_image/responsive_image.info.yml: patch does not apply
Checking patch core/modules/rest/rest.info.yml...
error: while searching for:
name: 'RESTful Web Services'
type: module
description: 'Exposes entities and other resources as RESTful web API'
package: Web services
version: VERSION
dependencies:
error: patch failed: core/modules/rest/rest.info.yml:1
error: core/modules/rest/rest.info.yml: patch does not apply
Checking patch core/modules/serialization/serialization.info.yml...
error: while searching for:
name: Serialization
type: module
description: 'Provides a service for (de)serializing data to/from formats such as JSON and XML.'
package: Web services
version: VERSION
error: patch failed: core/modules/serialization/serialization.info.yml:1
error: core/modules/serialization/serialization.info.yml: patch does not apply
Checking patch core/modules/shortcut/shortcut.info.yml...
error: while searching for:
name: Shortcut
type: module
description: 'Allows users to manage customizable lists of shortcut links.'
package: Core
version: VERSION
configure: entity.shortcut_set.collection
error: patch failed: core/modules/shortcut/shortcut.info.yml:1
error: core/modules/shortcut/shortcut.info.yml: patch does not apply
Checking patch core/modules/statistics/statistics.info.yml...
error: while searching for:
name: Statistics
type: module
description: 'Logs content statistics for your site.'
package: Core
version: VERSION
configure: statistics.settings
error: patch failed: core/modules/statistics/statistics.info.yml:1
error: core/modules/statistics/statistics.info.yml: patch does not apply
Checking patch core/modules/syslog/syslog.info.yml...
error: while searching for:
name: Syslog
type: module
description: 'Logs and records system events to syslog.'
package: Core
version: VERSION
configure: system.logging_settings
error: patch failed: core/modules/syslog/syslog.info.yml:1
error: core/modules/syslog/syslog.info.yml: patch does not apply
Checking patch core/modules/system/system.info.yml...
error: while searching for:
name: System
type: module
description: 'Handles general site configuration for administrators.'
package: Core
version: VERSION
required: true
error: patch failed: core/modules/system/system.info.yml:1
error: core/modules/system/system.info.yml: patch does not apply
Checking patch core/modules/system/tests/src/Functional/Module/PrepareUninstallTest.php...
Checking patch core/modules/text/text.info.yml...
error: while searching for:
name: Text
type: module
description: 'Defines simple text field types.'
package: Field types
version: VERSION
dependencies:
error: patch failed: core/modules/text/text.info.yml:1
error: core/modules/text/text.info.yml: patch does not apply
Checking patch core/modules/toolbar/toolbar.info.yml...
error: while searching for:
name: Toolbar
type: module
description: 'Provides a toolbar that shows the top-level administration menu links and links from other modules.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/toolbar/toolbar.info.yml:1
error: core/modules/toolbar/toolbar.info.yml: patch does not apply
Checking patch core/modules/tracker/tracker.info.yml...
Checking patch core/modules/update/update.info.yml...
error: while searching for:
name: 'Update Manager'
type: module
description: 'Checks for available updates, and can securely install or update modules and themes via a web interface.'
version: VERSION
package: Core
configure: update.settings
error: patch failed: core/modules/update/update.info.yml:1
error: core/modules/update/update.info.yml: patch does not apply
Checking patch core/modules/user/user.info.yml...
error: while searching for:
name: User
type: module
description: 'Manages the user registration and login system.'
package: Core
version: VERSION
required: true
error: patch failed: core/modules/user/user.info.yml:1
error: core/modules/user/user.info.yml: patch does not apply
Checking patch core/modules/views/views.info.yml...
error: while searching for:
name: Views
type: module
description: 'Create customized lists and queries from your database.'
package: Core
version: VERSION
dependencies:
error: patch failed: core/modules/views/views.info.yml:1
error: core/modules/views/views.info.yml: patch does not apply
Comment #72
Rinku Jacob 13 CreditAttribution: Rinku Jacob 13 commentedI have successfully applied the patch#68 for drupal version 9.4.x-dev. Adding screenshots for the reference
Comment #73
aarti zikre CreditAttribution: aarti zikre as a volunteer and at QED42 commentedComment #74
quietone CreditAttribution: quietone at PreviousNext commented@priyanka.sahni, if a patch does not apply locally just comment that it did not apply and the version of Drupal core you were using. Adding the terminal output is noise and doesn't advance the issue.
@Rinku Jacob 13, screenshots are not needed for this issue. It would be difficult to show all the strings and it would be better to just to manual testing and report back. And your screenshot just one of the many instances of changed text in the patch. Therefor, credit has been removed per How is credit granted for Drupal core issues.
@aarti zikre, thanks for the confidence in this patch. However, you comment should state what you did to confirm that this patch is ready to be committed to core.
Setting back to NW for manual testing.
Comment #75
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound for Valuebound commentedComment #76
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound for Valuebound commentedRe-rolled #68 patch.
Comment #77
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound for Valuebound commentedComment #78
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound for Valuebound commentedRe-rolled #68 patch.
Comment #79
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commentedComment #81
quietone CreditAttribution: quietone at PreviousNext commented@Munavijayalakshmi, Thanks for looking into this issue. The patch did not need a reroll. The patch still applies to 9.5. The previous comment, #74, states that the work needed here is manual testing. I am surprised that applying the patch locally didn't show that a reroll was not needed. Oh, looking at the patch, you were working on Drupal 8, which is no longer supported. And for future reference, when rerolling always provide an interdiff or a diff file and comment on what you did. There are instructions for creating an interdiff .
After making a few diffs and interdiffs, I see that the patch in #76 has introduced changes and errors. The strings for menu and migrate_drupal are 'Provides functionality to output responsive images using the HTML5 picture tag.'. which is incorrect. I'll upload the diffs I made. The patch in #79 is a reroll of the patch from #78, continuing the errors.
The patch to use here is the patch in #68. I will upload it again to help avoid confusion. I am not running tests, we can do that when this is ready for RTBC.
I have updated the remaining tasks in the Issue Summary.
I hope all that helps. This is so close ....
Comment #82
quietone CreditAttribution: quietone at PreviousNext commentedMeant to set to Needs review to get eyes on all the changes.
Comment #84
nod_By now I think the CKEditor 5 module is the only one that's not consisitent with the rest.
I'm not a native speaker so I can't say how good it is, for me the description reads fine. It's better than it used to be so RTBC.
Comment #85
longwavePatch needs reroll for 10.1.x. Now that the 9.5.0 and 10.0.0 release candidates are out I don't think we can backport this as it contains translatable string changes.
Comment #86
elberI will do a reroll
Comment #87
elberHi please revise.
Comment #88
nod_Thanks! unfortunately the patch contains some unrelated changes and files: .gitignore, .lando.yml, 3322094-5.patch. they're not related to this issue so they shouldn't appear in a patch here.
Rerolled and tried to update the CKE5 text, needs review :)
Comment #89
elberSorry @nod I forgot to see and delete it, but I will review your reroll
Comment #90
nod_no worries, there are days I need a fair bit of tries before uploading a complete patch too :)
Comment #91
elberHi I revised.
I was able to apply the reroll in Drupal 10.1.x version
descriptions are fine.
For me issue was resolved.
Comment #92
quietone CreditAttribution: quietone at PreviousNext commentedI read The help text standards, noting "The description starts with a verb and should be short and concise.'. I then applied the patch and read the changes on a Drupal 10.1.x, standard install. I notice the following, which do not meet that standard.
These do not start with a verb.
These are inconsistent.
And finally,
Migrate: Handles migrations. - This is insufficient. Something along the lines of "Provides a framework for migrating data to Drupal."
CKeditor 5: Provides a rich text editor for fields using CKEditor 5. - This is self referring. Maybe, 'Provides the CKEditor 5 rich text editor".
That is 8 lines to change. I checked the IS for scope and it does start out stating that this is a subset of the descriptions. Looking at the other issue this appears to be for fixing the ones not corrected there. So, I think this is in scope.
Setting to NW.
Comment #93
nod_Thanks :) Kinda cheated for the filter description but that's the limit of my skills with words.
Comment #94
Bhanu951 CreditAttribution: Bhanu951 as a volunteer commentedComment #95
longwaveWe could possibly drop the word "formats" here, but this is the only nit I could find. Marking RTBC as this all looks good again now.
Comment #96
quietone CreditAttribution: quietone at PreviousNext commentedTo other committers. I'd like to finish this one and commit in the next 24 hours. Thanks.
Comment #97
quietone CreditAttribution: quietone at PreviousNext commentedOr maybe not. I am having trouble with my signing key.
Comment #99
quietone CreditAttribution: quietone at PreviousNext commentedIt is very nice to have consistent language now on the modules page. Thanks!
This is a string change, see #9, so only eligible for 10.1.x.
Thanks everyone!