Tests are failing on drupal 8.8, button label has been changed in #3018073: Stop Using Title Case When Not Appropriate in Layout Builder UI

8.7 works fine

CommentFileSizeAuthor
#8 3060884-8.patch1.32 KBswentel
#2 3060884--2.patch885 bytesStryKaizer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Active » Needs review
FileSize
3060884--2.patch885 bytes
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Issue tags: +DevDaysTransylvania

Status: Needs review » Needs work

The last submitted patch, 2: 3060884--2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Title: Fix test » Test failing on 8.8
Priority: Normal » Minor
Issue summary: View changes
johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented

I have the same issue in Layout Builder Modal, and I was suggested to use selectors instead if possible. If not, I'd suggest to keep the 8.7.x branch tests green because that is the stable and target branch currently.

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented

Oh right, yeah, I'll see if can change them to using selectors

swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs work » Needs review
FileSize
3060884-8.patch1.32 KB

This should do the trick

  • swentel committed 4456134 on 8.x-2.x 
    Issue #3060884 by StryKaizer, swentel: Test failing on 8.8
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Needs review » Fixed
swentel’s picture

swentel CreditAttribution: swentel at eps & kaas for Dropsolid commented
Status: Fixed » Closed (fixed)