Based on feedback from niko- on https://www.drupal.org/project/facets/issues/2692027#comment-13121568
The All link in the checkbox widget cannot be clicked due to missing data attributes.

CommentFileSizeAuthor
#2 facets-reset-checkbox-links-3064344-2.patch1.21 KBrecrit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

recrit created an issue. See original summary.

recrit’s picture

recrit CreditAttribution: recrit commented
Status: Active » Needs review
FileSize
facets-reset-checkbox-links-3064344-2.patch1.21 KB

The attached patch uses the method buildListItems() to consistently build the reset link for any widget.

borisson_ credited niko-.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
gge’s picture

gge CreditAttribution: gge commented

I just applied the patch and now "Show All" checkbox is working just fine.

Thank you!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Reviewed & tested by the community

RTBC based on @gge's feedback.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Commited and pushed, thanks.

  • borisson_ committed c944e1d on 8.x-1.x authored by recrit 
    Issue #3064344 by recrit, niko-: "All" link in facets: Fix Checkbox...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

recrit’s picture

recrit CreditAttribution: recrit at Phase2 commented