Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There is a overlooked issue with the line that sets the amount of the payment. It was probably meaning to cast the result of the calculation to a string, but instead casts the value being devided to a string, resulting in an InvalidArgumentException if there is a decimal amount.
Patch coming up
Comment | File | Size | Author |
---|---|---|---|
#9 | 3064776-9.patch | 8.75 KB | zaporylie |
| |||
#7 | 3064776-7.patch | 8.39 KB | zaporylie |
| |||
#5 | 3064776-5.patch | 8.09 KB | zaporylie |
| |||
#3 | 3064776-3.patch | 8.09 KB | zaporylie |
#2 | 3064776.patch | 897 bytes | eiriksm |
Comments
Comment #2
eiriksmPatch attached. Will create a follow up to create a test, since that should be fairly simple to create.
Comment #3
zaporylieI refactored the class a bit to make it easier for write a test, which I also wrote. I found two more places where parenthesis were missing but I haven't had time to write tests for those as tests would have to be functional. That test coverage can be added later.
Comment #5
zaporylieFixes the test namespace. Hopefully that will make tests to work in DrupalCI environment.
Comment #7
zaporylieTests were discovered! (damn typo)
Now seems like the test_dependency is missing.
Comment #9
zaporylieAs per https://www.drupal.org/docs/develop/using-composer/managing-dependencies... seems like test_dependencies must be committed to default branch before they are discovered by DrupalCi, hence I'm adding relevant test dependencies to require-dev section of composer.json.
Comment #11
zaporylie