The 8.x-1.x-beta2 release currently has a number of errors in the code, and some extraneous code which is no longer used. It's been a year since anyone pushed a commit to the repo while there are a number of patches that are ready to go into production. As the current beta release is not fully functioning, these commits would vastly improve the utility of this branch of the module. It presently not being included in the VarBase profile due to the beta status: #3062283: Add and enable [Generate Password] module ( ~1.0 ).

I would like to step on board to commit the existing patches provided and fix up any other outstanding issues to create a more fully functioning release of the module for the D8 users. At least a beta3, possibly rc1, and the finally the 1.0 release.

I have created a sandbox with a fork of the existing module's 8.x-1.x branch will all of the commits I would include to create the 8.x-1.x RC or full release. The sandbox is branched off the 8.x-1.x dev branch of the main repo.
sandbox: https://www.drupal.org/sandbox/elc/3065977
commits: https://www.drupal.org/node/3065977/commits (credited to those users who provided the code)

There is currently a release blocker issue at present in that #3065774: Automated testing failing due to module not having tests. At least one test needs to be devised and added to the code.

These are the outstanding issues that are addressed in the commits included in the sandbox above:
#3065556: Fix attached genpass/genpass library name and coding standard
#3017703: Drupal set message deprecated
#2996146: Coding standard
#2996150: InitSubscriber class; library not included correctly
#3065522: HTML shows in password messages, no admin message
#3065521: Remove config on uninstall is automatic, does not involve queue
#1811780: Update genpass_password to include best elements of Drupal 7 user_password

The following issue has changes to how the password is generated in the 7.x-2.x branch of the code. The changes in how passwords are generated, which is to include at least one character of each class to increase final password entropy, would be another patch to be ported into the 8.x-1.x branch at some point. There are also some UI change which make a lot of sense to include in the D8 branch.
#2975168: Genpass 7.x-2.x

Comments

ELC created an issue. See original summary.

greggles’s picture

I'm +1 on this. Thanks for all your work in the queue! I'd like to give it another 2 weeks for other maintainers to respond.

Rajab Natshah’s picture

I'm with having Ted. I think 2 weeks are over

greggles’s picture

Status: Active » Fixed

Cool, thanks for the ping, RajabNatshah. This is now fixed: ELC is a co-maintainer.

greggles’s picture

Updating credit.

ELC’s picture

Thank you both!

As is always the way, I've been swamped with the project I needed this module for but, I'll have a bit of free time coming up for this soon.

In using the module I have found a couple of functionality issues which should probably be addressed so I'll see about adding them in before a release too.

I'll add them to either existing issues or new ones, but the settings need a little re-jig, and I think the showing of the password should be controlled by a permission instead of a setting. I ran into this issue because my create user isn't on "/user/register" or "user.admin_create" because I'm using multiple registrations module to control the fields for each role.

That's a fairly significant change to settings .. current release is "beta", and normally that wouldn't warrant a hook_update_N(), but there are ~1000 sites using the module. I think that warrants breaking protocol and including an update if I end up breaking settings.

Anyway, issues for the queue and not here. Thanks again! I'll get my butt in gear soon.

greggles’s picture

Yes, I think even in beta state that variables should be migrated to a new system. Thanks!

Rajab Natshah’s picture

Thank you :)
Following with Ted's work
#3065774: Automated testing failing due to module not having tests
I hope if anyone of old Maintainers for Generate Password could have time to write the main testing scenarios, which they could be implemented.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.