Please check and apply the Drupal coding standards.

(1.)

 ------ -------------------------------------------------------------------------------------
  Line   src\Plugin\SmsGateway\SmsRu.php
 ------ -------------------------------------------------------------------------------------
         Class Drupal\sms\Plugin\SmsGatewayPluginBase not found and could not be autoloaded.
 ------ -------------------------------------------------------------------------------------

(2.) README.md or README.txt is missing. Please see the guidelines for in-project documentation.

(3.)

FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/Auth/AuthInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Client/ClientInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 21 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------
CommentFileSizeAuthor
#2 3068717-2.patch676 bytesvuil
pareview-errors.jpg42.48 KBvuil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

FileSize
676 bytes
vuil’s picture

Status: Active » Needs review
Niklan’s picture

Status: Needs review » Needs work

Hi, this method returns ResponseInterface, not Request. This is type hinted directly in the method.

vuil’s picture

Title: Fixed the PAReview issues » Apply Drupal coding standards
Status: Needs work » Needs review

The Drupal coding staandards are applied.

Niklan’s picture

Status: Needs review » Needs work

The patch needs more work to be done.

diff --git a/src/Client/ClientInterface.php b/src/Client/ClientInterface.php
index e90c0d7..146e0b4 100644
--- a/src/Client/ClientInterface.php
+++ b/src/Client/ClientInterface.php
@@ -19,6 +19,7 @@ interface ClientInterface {
    *   The API params send with request.
    *
    * @return mixed
+   *   The API request.
    */
   public function request(string $endpoint, array $params = []): ResponseInterface;

The Drupal\smsru\Client\ClientInterface::request() return Drupal\smsru\Response\ResponseInterface not "The API request". Also its also incorrect that it typhinted in comment as "mixed" it is strictly typed actually as it typehinted in the method.

Summary:

1. The description is incorrect. It must be "The API response."
2. The "mixed" type-hint for @return is also incorrect. It must be Drupal\smsru\Response\ResponseInterface

vuil’s picture

Issue summary: View changes

Update the issue's summary after three months non-activity.

Niklan’s picture

Status: Needs work » Fixed

  • Niklan committed d259948 on 8.x-1.x
    Issue #3068717 by vuil, Niklan: Apply Drupal coding standards
    
andypost’s picture

Status: Needs work » Fixed
vuil’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.