Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Please check and apply the Drupal coding standards.
(1.)
------ -------------------------------------------------------------------------------------
Line src\Plugin\SmsGateway\SmsRu.php
------ -------------------------------------------------------------------------------------
Class Drupal\sms\Plugin\SmsGatewayPluginBase not found and could not be autoloaded.
------ -------------------------------------------------------------------------------------
(2.) README.md or README.txt is missing. Please see the guidelines for in-project documentation.
(3.)
FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/Auth/AuthInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
18 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Client/ClientInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
21 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#2 | 3068717-2.patch | 676 bytes | vuil |
pareview-errors.jpg | 42.48 KB | vuil |
Comments
Comment #2
vuilComment #3
vuilComment #4
NiklanHi, this method returns ResponseInterface, not Request. This is type hinted directly in the method.
Comment #5
vuilThe Drupal coding staandards are applied.
Comment #6
NiklanThe patch needs more work to be done.
The
Drupal\smsru\Client\ClientInterface::request()
returnDrupal\smsru\Response\ResponseInterface
not "The API request". Also its also incorrect that it typhinted in comment as "mixed" it is strictly typed actually as it typehinted in the method.Summary:
1. The description is incorrect. It must be "The API response."
2. The "mixed" type-hint for
@return
is also incorrect. It must beDrupal\smsru\Response\ResponseInterface
Comment #7
vuilUpdate the issue's summary after three months non-activity.
Comment #8
NiklanComment #10
andypostComment #11
vuil